-
Notifications
You must be signed in to change notification settings - Fork 50
chore: added string for NSBluetoothAlwaysUsageDescription #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task —— View job Post-merge Review Complete
Review FindingsIssue 1: Incomplete permission configuration (dapps/pos-app/app.json:21) The PR adds
Issue 2: Permission scope mismatch (dapps/pos-app/app.json:18-22, 122-128) The
Issue 3: Android permission asymmetry (dapps/pos-app/app.json:39-46) Android configuration includes multiple Bluetooth permissions (BLUETOOTH, BLUETOOTH_ADMIN, BLUETOOTH_CONNECT, BLUETOOTH_SCAN, BLUETOOTH_ADVERTISE), but there's no corresponding user-facing permission description in Android's manifest. While not technically required for Android (permissions are granted at install), consider adding descriptive text for consistency and user transparency. Since this PR is already merged, these issues would need to be addressed in a follow-up PR if changes are desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds iOS Bluetooth permission configuration to support the app's receipt printing functionality via Bluetooth thermal printers. The change adds a user-facing permission description to explain why Bluetooth access is required.
- Added
NSBluetoothAlwaysUsageDescriptionto iOSinfoPlistconfiguration - Permission description follows existing pattern with clear explanation of Bluetooth usage for printing receipts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| "NFCReaderUsageDescription": "This app requires NFC to send messages", | ||
| "NSLocationWhenInUseUsageDescription": "This app requires location when using the camera" | ||
| "NSLocationWhenInUseUsageDescription": "This app requires location when using the camera", | ||
| "NSBluetoothAlwaysUsageDescription": "This app requires Bluetooth to print receipts" |
Copilot
AI
Nov 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key NSBluetoothAlwaysUsageDescription has been deprecated since iOS 13. For apps that connect to Bluetooth peripherals (like printers), the correct key to use is NSBluetoothPeripheralUsageDescription. Consider updating this to use the recommended key:
"NSBluetoothPeripheralUsageDescription": "This app requires Bluetooth to print receipts"This ensures compatibility with current iOS versions and follows Apple's current guidelines.
| "NSBluetoothAlwaysUsageDescription": "This app requires Bluetooth to print receipts" | |
| "NSBluetoothPeripheralUsageDescription": "This app requires Bluetooth to print receipts" |
This pull request adds a new permission description to the app configuration to support Bluetooth functionality. The change clarifies to users why Bluetooth access is required.
Permissions update:
NSBluetoothAlwaysUsageDescriptionto theinfoPlistindapps/pos-app/app.json, explaining that Bluetooth is needed to print receipts.