Skip to content

Commit 4cae9df

Browse files
authored
Merge pull request kubernetes-sigs#2970 from sbueringer/pr-remove-sync
🌱 Remove deprecated cluster.Options.SyncPeriod
2 parents 3f6485a + 4165a9b commit 4cae9df

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

pkg/cluster/cluster.go

-14
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"context"
2121
"errors"
2222
"net/http"
23-
"time"
2423

2524
"github.com/go-logr/logr"
2625
"k8s.io/apimachinery/pkg/api/meta"
@@ -88,16 +87,6 @@ type Options struct {
8887
// If none is set, it defaults to log.Log global logger.
8988
Logger logr.Logger
9089

91-
// SyncPeriod determines the minimum frequency at which watched resources are
92-
// reconciled. A lower period will correct entropy more quickly, but reduce
93-
// responsiveness to change if there are many watched resources. Change this
94-
// value only if you know what you are doing. Defaults to 10 hours if unset.
95-
// there will a 10 percent jitter between the SyncPeriod of all controllers
96-
// so that all controllers will not send list requests simultaneously.
97-
//
98-
// Deprecated: Use Cache.SyncPeriod instead.
99-
SyncPeriod *time.Duration
100-
10190
// HTTPClient is the http client that will be used to create the default
10291
// Cache and Client. If not set the rest.HTTPClientFor function will be used
10392
// to create the http client.
@@ -194,9 +183,6 @@ func New(config *rest.Config, opts ...Option) (Cluster, error) {
194183
if cacheOpts.HTTPClient == nil {
195184
cacheOpts.HTTPClient = options.HTTPClient
196185
}
197-
if cacheOpts.SyncPeriod == nil {
198-
cacheOpts.SyncPeriod = options.SyncPeriod
199-
}
200186
}
201187
cache, err := options.NewCache(config, cacheOpts)
202188
if err != nil {

0 commit comments

Comments
 (0)