prepare for 4.0

- updates tests to work with Bundler.require
- makes all pronto runner gems optionally required (preserves existing
  behavior)
- adds one test to run pronto with all available runners
- adds changelog info about breaking changes and upgrades
- updates test.git to have an erb-lint.yml since erb-lint has some
  issues using String#yellow without bundling a dep that includes that

Author: jbielick

.rspec

@@ -1,2 +1,3 @@
 --color
+--format documentation
 --require spec_helper

CHANGELOG.md

@@ -1,3 +1,21 @@
+4.0 | 2022-03-17
+---
+
+**BREAKING CHANGES:**
+
+ * Pronto is upgraded to 0.11, the following runners are not yet compatible:
+   - pronto-poper
+   - pronto-rails_data_schema
+
+Changes:
+
+ * Upgrades node.js to 14.x
+ * Upgrades eslint_npm to 7.32.0
+ * Upgrades stylelint to 13.13.1
+ * Upgrades Bundler to 2.3.8
+ * Upgrades Rubocop to 1.26.0
+ * Upgrades all runners and dependencies
+
 2.5 | 2020-03-24
 ---
 

CONTRIBUTING.md

@@ -20,7 +20,7 @@ Finally, create a release through GitHub's UI with a version bump and include CH
 
 # Tests
 
-Using `bundler/setup` in the test environment clears the load path for ruby, which prevents us from requiring gems that are already installed like `pronto` and the runners. For this reason, it is important not to use `Bundler.require` or `bundler/setup` in the test environment so that we can require gems from both the Gemfile _and_ those installed in the _base image_.
+Unzip the test git archive: `make spec/fixtures/test.git`
 
 The test suite uses RSpec and WebMock.
 

Gemfile

@@ -16,7 +16,7 @@ gem 'pronto-reek', require: false
 gem 'pronto-flay', require: false
 gem 'pronto-fasterer', require: false
 gem 'pronto-scss', require: false
-gem 'pronto-erb_lint', '~>0.1', require: false
+gem 'pronto-erb_lint', require: false
 gem 'pronto-stylelint', require: false
 
 gem 'rubocop-performance', require: false

Gemfile.lock

@@ -25,9 +25,9 @@ GEM
       smart_properties
     brakeman (5.2.1)
     builder (3.2.4)
-    bundler-audit (0.7.0.1)
+    bundler-audit (0.9.0.1)
       bundler (>= 1.2.0, < 3)
-      thor (>= 0.18, < 2)
+      thor (~> 1.0)
     climate_control (1.0.1)
     code_analyzer (0.5.5)
       sexp_processor
@@ -124,9 +124,9 @@ GEM
     pronto-brakeman (0.11.1)
       brakeman (>= 3.2.0)
       pronto (~> 0.11.0)
-    pronto-bundler_audit (0.6.0)
-      bundler-audit (~> 0)
-      pronto (~> 0)
+    pronto-bundler_audit (0.7.0)
+      bundler-audit (~> 0.8)
+      pronto (~> 0.11)
     pronto-erb_lint (0.1.5)
       erb_lint (~> 0.0.24)
       pronto (> 0.9.0)
@@ -233,7 +233,7 @@ GEM
     ruby2_keywords (0.0.5)
     ruby_parser (3.18.1)
       sexp_processor (~> 4.16)
-    rugged (0.99.0)
+    rugged (1.0.1)
     sass (3.7.4)
       sass-listen (~> 4.0.0)
     sass-listen (4.0.0)
@@ -248,7 +248,7 @@ GEM
     smart_properties (1.17.0)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
-    thor (0.20.3)
+    thor (1.2.1)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
@@ -265,7 +265,7 @@ DEPENDENCIES
   pronto
   pronto-brakeman
   pronto-bundler_audit
-  pronto-erb_lint (~> 0.1)
+  pronto-erb_lint
   pronto-eslint_npm
   pronto-fasterer
   pronto-flay

pronto

@@ -2,9 +2,9 @@
 
 require 'rubygems'
 require 'bundler/setup'
-require 'pronto'
-require 'pronto/cli'
+Bundler.require(:default)
 require_relative './src/github_action_check_run_formatter'
+require 'pronto/cli'
 
 # github action inputs can only be strings, so when we passes the runners
 # list to this container, github passes container command args quoted like this:

spec/all_spec.rb

@@ -0,0 +1,7 @@
+RSpec.describe 'all pronto runners' do
+  it 'run without error' do
+    Dir.chdir('spec/fixtures/test.git') do
+      Pronto::CLI.start(%w(run))
+    end
+  end
+end

spec/fixtures/test.git.tar.gz

@@ -1,6 +1,3 @@
-require 'pronto/cli'
-require 'src/github_action_check_run_formatter'
-
 RSpec.describe Pronto::Formatter::GithubActionCheckRunFormatter do
 
   STUBBED_ENV = {
@@ -14,24 +11,17 @@
     end
   end
 
-  after do
-    Pronto::Runner.repository.clear
-  end
-
   context 'when the runner is rubocop' do
     it 'posts a check run with annotations' do
       check_runs_url = "https://api.github.com/repos/Codertocat/Hello-World/check-runs"
       post_stub = stub_request(:post, check_runs_url).to_return(
         {status: 201, body: '{"id": 1}'},
         {status: 201, body: '{"id": 2}'},
       )
+      allow(Pronto::Runner).to receive(:repository).and_return([Pronto::Rubocop])
 
       Dir.chdir('spec/fixtures/test.git') do
-        Pronto::CLI.start(%w(
-          run
-          -r rubocop
-          -f github_action_check_run
-        ))
+        Pronto::CLI.start(%w(run -f github_action_check_run))
       end
 
       expect(
@@ -115,13 +105,10 @@
         {status: 201, body: '{"id": 1}'},
         {status: 201, body: '{"id": 2}'},
       )
+      allow(Pronto::Runner).to receive(:repository).and_return([Pronto::YAMLLint])
 
       Dir.chdir('spec/fixtures/test.git') do
-        Pronto::CLI.start(%w(
-          run
-          -r yamllint
-          -f github_action_check_run
-        ))
+        Pronto::CLI.start(%w(run -f github_action_check_run))
       end
 
       expect(
@@ -170,13 +157,10 @@
       {status: 201, body: '{"id": 1}'},
       {status: 201, body: '{"id": 2}'},
     )
+    allow(Pronto::Runner).to receive(:repository).and_return([Pronto::Poper])
 
     Dir.chdir('spec/fixtures/test.git') do
-      Pronto::CLI.start(%w(
-        run
-        -r poper
-        -f github_action_check_run
-      ))
+      Pronto::CLI.start(%w(run -f github_action_check_run))
     end
 
     expect(

spec/github_action_check_run_formatter_spec.rb

@@ -1,4 +1,7 @@
-require 'climate_control'
-require 'pry'
 require 'webmock/rspec'
+require 'rubygems'
+require 'bundler/setup'
+Bundler.require(:default, :test)
+require 'pronto/cli'
 $LOAD_PATH.push(File.dirname(__dir__))
+require 'src/github_action_check_run_formatter'