Loaders not reevaluated when navigating to a route with the same path+hash but different state

[pekala]

I'm using React Router as a...

library

Reproduction

• Go to https://codesandbox.io/p/sandbox/condescending-morning-49tz97
• Click on "Nested route without hash"
• Click on "Same path+hash, different state" a few times
• Click on "Nested route with hash"
• Click on "Same path+hash, different state" a few times

System Info

Codesandbox

Used Package Manager

npm

Expected Behavior

I'd expect the loaders to re-run if the link with a different URL state is clicked, as they have shouldRevalidate returning true.

Actual Behavior

On links without hash, the loaders revalidate as expected. However, when hashes are present, the loaders stay stale. We're hitting the short circuit in startNavigation due to this branch in isHashChangeOnly. My suggestion would be to check if state was not changed in

react-router/packages/react-router/lib/router/router.ts

Line 5323 in 94158cf

if (a.pathname !== b.pathname || a.search !== b.search) {

and if it was, not short circuit.

[skovhus]

This is still an issue.