Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can location.pathname be defaulted to window.location.pathname ? #831

Open
amatthieu opened this issue Sep 1, 2020 · 0 comments
Open

Can location.pathname be defaulted to window.location.pathname ? #831

amatthieu opened this issue Sep 1, 2020 · 0 comments

Comments

@amatthieu
Copy link

Why use a default location.pathname to / ?

I wonder if there's a reason to it or if we can use window.location.pathname instead.
This would be useful to apps that are not based on / and they would not have to set a basename when they call createBrowserHistory.

This is a proposal, and my first on this project 😅
I couldn't find another issue on this so sorry if it's a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant