Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright message missing in javascript #826

Open
samirbhagwat opened this issue Aug 14, 2020 · 2 comments
Open

Copyright message missing in javascript #826

samirbhagwat opened this issue Aug 14, 2020 · 2 comments

Comments

@samirbhagwat
Copy link

I pulled npm history install for 4.10.1 and later checked the file : node_modules/history/cjs/history.js and history.min.js and didn't find copyright message.
The MIT License (and your license) states: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

Issue is to track copyright message into javascript file as per MIT license.

@samirbhagwat samirbhagwat changed the title Copyright message message missing in javascript Copyright message missing in javascript Aug 14, 2020
@StringEpsilon
Copy link

The license file is provided with the package. That should be sufficient for the MIT in terms of publishing a work on NPM.

4.10.1: https://unpkg.com/browse/[email protected]/LICENSE

5.0.0: https://unpkg.com/browse/[email protected]/LICENSE

If you bundle and ship the library, you have to ensure compliance with the MIT yourself - like with a whole lot of other npm packages.

@samirbhagwat
Copy link
Author

So in short if we bundle and ship:
/history/udm/history.js & /history/udm/history.min.js and also include /history/LICENSE
this will be compliant right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants