Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Privacy" section is missing "Screen" subsection #4

Open
mfisher87 opened this issue Jun 29, 2022 · 2 comments
Open

"Privacy" section is missing "Screen" subsection #4

mfisher87 opened this issue Jun 29, 2022 · 2 comments

Comments

@mfisher87
Copy link
Member

In Gnome Control Center, the "Privacy" subsection contains options for how the screen is locked, for example, do I want the screen to lock after suspend?

The Regolith CC is missing that subsection as well as "Connectivity" and "Diagnostics" sections.

The attached screenshot shows two windows: Regolith CC in background and Gnome CC in foreground, both with the "Privacy" section open.

image

I manually applied the desired setting with: gsettings set org.gnome.desktop.screensaver ubuntu-lock-on-suspend 'false' but would have preferred to not have to look that attribute up :)

Relevant Slack post: https://regolith-linux.slack.com/archives/CLYDASBFS/p1656500959733479

Thanks for your wonderful work :)

Matt
@kgilmer
Copy link
Member

kgilmer commented Jun 30, 2022

Thanks for the detailed bug report Matt! Just curious, can you not just use gnome-control-center for that particular setting or was there something that required you to set it via gsettings?

So, a primary reason for the fork of gnome-control-center to regolith-control-center is that many (and increasing over time) of the features expressed in the upstream directly map to features in gnome-shell. Because Regolith uses the i3 WM, these features simple don't do anything. This causes a lot of confusion so we removed things that were not related to Regolith. Perhaps we cut too deep in this case. I'll take a look. But, in any case the fork is designed in such a way that the upstream gnome-control-center should continue to work as-is in Regolith so if there is a particular setting you need, you can use it for those.

@mfisher87
Copy link
Member Author

Thanks Ken for the response!

When I originally encountered this issue, I had forgotten that the gnome-control-center was still installed alongside regolith's, and that's why I went down the road of changing the value at the CLI. I thought I had removed gnome-cc, but IIRC it's a dependency of regolith-control-center so it was never actually removed. I just deleted the /usr/share/applications entry to get rid of what I saw as a "duplicate" on my launcher.

In any case, I had figured that out when I went to document the issue here and take the screenshot that includes both GUI apps :)

Apologies for the confused nature of the report, I must not have been fully awake.

kgilmer pushed a commit that referenced this issue Jul 29, 2022
@hadess
online-accounts: Fix feature switches not doing anything
1e1fbd6 
Make sure to keep a reference to the GoaObject of the account around so
that the GBinding that synchronises each switch widget and the account
properties don't get finalized on startup.

 #0  0x00007ffff73c6a20 in g_binding_finalize () at /lib64/libgobject-2.0.so.0
 #1  0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #2  0x00007ffff73c68e8 in weak_unbind () at /lib64/libgobject-2.0.so.0
 #3  0x00007ffff73cf117 in weak_refs_notify () at /lib64/libgobject-2.0.so.0
 #4  0x00007ffff72acd6c in g_data_set_internal () at /lib64/libglib-2.0.so.0
 #5  0x00007ffff73d0195 in g_object_real_dispose.lto_priv () at /lib64/libgobject-2.0.so.0
 #6  0x00007ffff73d3c44 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #7  0x00007ffff72b6793 in g_hash_table_remove_all_nodes.part () at /lib64/libglib-2.0.so.0
 #8  0x00007ffff72ba723 in g_hash_table_unref () at /lib64/libglib-2.0.so.0
 #9  0x00007ffff753403d in g_dbus_object_proxy_finalize () at /lib64/libgio-2.0.so.0
 #10 0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #11 0x0000000000402d08 in glib_autoptr_clear_GoaObject (_ptr=0x5d59f0) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #12 glib_autoptr_cleanup_GoaObject (_ptr=<synthetic pointer>) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #13 on_application_activate_show_account_cb (application=0x49f2f0, argv=<optimized out>) at ../../../../Projects/jhbuild/gnome-control-center/panels/online-accounts/gnome-control-center-goa-helper.c:360

Closes: #1721
kgilmer pushed a commit that referenced this issue Jul 29, 2022
@hadess
shell: Initialise locale early
95de204 
Otherwise glib will make internal calls before setlocale is called:
** (process:1124144): WARNING **: 10:16:58.983: dcgettext("(null)", "", 5) called before setlocale()

 #0  0x00007ffff7c80f77 in g_logv () at /lib64/libglib-2.0.so.0
 #1  0x00007ffff7c81233 in g_log () at /lib64/libglib-2.0.so.0
 #2  0x00007ffff7fbb6c6 in dcgettext (__domainname=<optimized out>, __msgid=0x7ffff7ce6c5a "", __category=<optimized out>) at ../../../../Projects/jhbuild/gettext-pseudolocale/gettext-pseudolocale.c:194
 #3  0x00007ffff7c6478e in _g_dgettext_should_translate () at /lib64/libglib-2.0.so.0
 #4  0x00007ffff7c6484b in g_dgettext () at /lib64/libglib-2.0.so.0
 #5  0x00007ffff7e98974 in g_application_class_intern_init () at /lib64/libgio-2.0.so.0
 #6  0x00007ffff7d9cfb8 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #7  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #8  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #9  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #10 0x00007ffff7d8671a in g_object_new_valist () at /lib64/libgobject-2.0.so.0
 #11 0x00007ffff7d867fd in g_object_new () at /lib64/libgobject-2.0.so.0
 #12 0x0000000000449bcc in cc_application_new () at ../../../../Projects/jhbuild/gnome-control-center/shell/cc-application.c:294
 #13 0x0000000000448fa6 in main (argc=1, argv=0x7fffffffd138) at ../../../../Projects/jhbuild/gnome-control-center/shell/main.c:55
kgilmer pushed a commit that referenced this issue Nov 28, 2022
@lkundrak @felipeborges
network: Fix an assertion failure
ad0db36 
Entering the Wi-Fi page without connected to a network trips an
assertion failure:

  (gnome-control-center:14943): nm-CRITICAL **: 16:36:16.732: nm_access_point_get_frequency: assertion 'NM_IS_ACCESS_POINT(ap)' failed

  Thread 1 "gnome-control-c" received signal SIGTRAP, Trace/breakpoint trap.
  0x00007ffff7c8ee51 in g_logv () from /lib64/libglib-2.0.so.0
  (gdb) bt
  #0  0x00007ffff7c8ee51 in g_logv () at /lib64/libglib-2.0.so.0
  #1  0x00007ffff7c8f0d3 in g_log () at /lib64/libglib-2.0.so.0
  #2  0x00007ffff63b7b8a in nm_access_point_get_frequency () at /lib64/libnm.so.0
  #3  0x00000000005965b1 in connect_details_page (self=0x4658210) at ../panels/network/connection-editor/ce-page-details.c:264
  #4  0x0000000000597f9e in ce_page_details_new (connection=0xfbde70, device=0xd52360, ap=0x0, editor=0x50a4350) at ../panels/network/connection-editor/ce-page-details.c:570
  #5  0x0000000000593273 in net_connection_editor_set_connection (self=0x50a4350, connection=0x7fffcc096770) at ../panels/network/connection-editor/net-connection-editor.c:522
  #6  0x0000000000593f7d in net_connection_editor_new (connection=0x7fffcc096770, device=0xd52360, ap=0x0, client=0xd3a0c0) at ../panels/network/connection-editor/net-connection-editor.c:790
  #7  0x0000000000582b16 in show_details_for_row (self=0xcc3040, row=0x46587b0, list=0x4273b40) at ../panels/network/net-device-wifi.c:987
  #8  0x00007ffff7d83845 in g_cclosure_marshal_VOID__OBJECTv () at /lib64/libgobject-2.0.so.0
  #9  0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #10 0x00007ffff7da1eb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
  #11 0x000000000058d41f in on_row_configured_cb (self=0x4273b40, row=0x46587b0) at ../panels/network/cc-wifi-connection-list.c:251
  #12 0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #13 0x00007ffff7da1eb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
  #14 0x000000000058c4c4 in configure_clicked_cb (self=0x46587b0) at ../panels/network/cc-wifi-connection-row.c:513
  #15 0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #16 0x00007ffff7da1cb3 in g_signal_emit () at /lib64/libgobject-2.0.so.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgilmer @mfisher87