Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regolith-control-center crash #2

Open
ploum opened this issue Apr 12, 2022 · 16 comments
Open

regolith-control-center crash #2

ploum opened this issue Apr 12, 2022 · 16 comments
Assignees
Labels
bug Something isn't working

Comments

@ploum
Copy link

ploum commented Apr 12, 2022

version 1.41.9-1regolith is crashing
stderr :
cc.txt

stdout :

Bail out! ERROR:../shell/cc-shell-model.c:419:cc_shell_model_set_panel_visibility: assertion failed: (valid)

@kgilmer
Copy link
Member

kgilmer commented Apr 23, 2022

Possibly related (from slack):

Just tried regolith-control-center and get the following error (on Pop_OS! 22.04 Beta with X and Intel/Nvidia Hybrid mode):
➤ regolith-control-center
../src/intel/isl/isl.c:2212: FINISHME: ../src/intel/isl/isl.c:isl_surf_supports_ccs: CCS for 3D textures is disabled, but a workaround is available.
** (regolith-control-center:130801): WARNING **: 10:45:46.272: Ignoring broken panel diagnostics (missing desktop file)
**
ERROR:../shell/cc-shell-model.c:419:cc_shell_model_set_panel_visibility: assertion failed: (valid)
Bail out! ERROR:../shell/cc-shell-model.c:419:cc_shell_model_set_panel_visibility: assertion failed: (valid)
fish: Job 1, 'regolith-control-center' terminated by signal SIGABRT (Abort)

@karl-run
Copy link

karl-run commented May 9, 2022

Running on Pop!_OS 22.04, regolith-control-center 41.4, when running from the terminal:

➜  ~ regolith-control-center -v
** (regolith-control-center:36530): WARNING **: 21:22:41.302: Ignoring broken panel diagnostics (missing desktop file)
** (regolith-control-center:36530): ERROR **: 21:22:41.304: Error in cc_shell_model_set_panel_visibility, unknown panel id: diagnostics
[1]    36530 trace trap (core dumped)  regolith-control-center -v

@TS-CUBED
Copy link

This error seems to be Pop_OS! specific. Pop_OS! has made some changes to gnome-control-center and I assume Regolith does not address these differences when setting up regolith-control-center.

@ploum
Copy link
Author

ploum commented May 13, 2022

Error happens on a straight Ubuntu 22.04

@dubbe
Copy link

dubbe commented May 13, 2022

I got the same issue as karl-run on Pop!_ OS 22.04

@kgilmer
Copy link
Member

kgilmer commented May 14, 2022

I cannot reproduce this, any hints?

On Jammy, I've tried manually setting last-panel to diagnostics but it does not result in a crash on version 1.41.11 via gsettings set org.gnome.ControlCenter last-panel "diagnostics".

It seems that there may be a codepath from dbus that's causing the crash but unsure of how to trigger it. I need to repro on Ubuntu.

@kgilmer kgilmer added the help wanted Extra attention is needed label May 14, 2022
kgilmer added a commit that referenced this issue May 21, 2022
@ploum
Copy link
Author

ploum commented May 22, 2022

I’ve reproduced this bug with an empty $home, which means that the issue is not related to any user preference.

Is there a way to help with some meaningful trace? I could give some strace output if I knew which arguments were useful in this case.

@kgilmer
Copy link
Member

kgilmer commented May 22, 2022

Are you just running regolith-control-center and it directly crashes? Any steps I can reproduce? See the commit above for a possible fix, are you able to build and verify? Should I build and send you a binary for testing?

@ploum
Copy link
Author

ploum commented May 23, 2022

yep, running directly and it crashes. You could either send me the instructions to build it or a binary, whatever is easier for you (no idea how to build this thing). I’m just trying to not mess with the / system (so no make install) and building it in a local folder.

@kgilmer
Copy link
Member

kgilmer commented May 24, 2022

I was able to build in jammy with the following steps:
(unfortunately there are a lot of patches in the debian dir so it's not possible to simply build directly w/ meson, we have to use the deb tools so that patches are applied)

git clone [email protected]:regolith-linux/regolith-control-center.git
cd regolith-control-center/
git checkout invalid-panel-fix-jammy
sudo apt build-dep -y .  # This will install all build-scope package dependencies
debuild -i -us -uc -b  # debuild comes from the package devscripts
debian/regolith-control-center/usr/bin/regolith-control-center # this is the built test target

@revkarol
Copy link

I eventually got this building with jammy (on Pop OS 22.04) - a lot of complaints about positional arguments in i18n.merge_file from meson - I guess that's a version thing (I have meson 0.61.2). Then after building I got the same error as @ploum (which I also get when running the standard apt installed version). I hacked away the assert on line 427 of shell/cc-shell-model.c
Then it ran ok, until I opened the mouse tab and it died again with the error
Settings schema 'org.gnome.settings-daemon.peripherals.mouse' is not installed. I can't really spot many differences between this variant and the Pop OS version (apart from the crashing obviously). So I can live without it myself (even if I don't get to see the nice Regolith logo in my about tab 😞 ). I'm just hacking about without much expertise here. Otherwise beta2 is working pretty well for me 😃 Hope this is helpful.

kgilmer added a commit that referenced this issue May 25, 2022
@kgilmer
Copy link
Member

kgilmer commented May 25, 2022

Thanks for spending the time to do the repro @revkarol , very helpful. I've been able to install popos in a VM and see the problem so hopefully I can figure out a fix shortly.

@kgilmer
Copy link
Member

kgilmer commented May 25, 2022

Potential fix building in https://github.com/regolith-linux/voulage/actions/runs/2382065776

To test this fix you'll need to update your Regolith repo from release to testing. To do this, update the s3 url in the apt sources file and replace release with testing.

$ cat /etc/apt/sources.list.d/regolith.list 
deb [arch=amd64] https://regolith-release-debian-bullseye-amd64.s3.amazonaws.com bullseye main

to

$ cat /etc/apt/sources.list.d/regolith.list 
deb [arch=amd64] https://regolith-testing-debian-bullseye-amd64.s3.amazonaws.com bullseye main

Keep in mind that the rest of the source is likely different than what I have here. The only part that changes is release to testing.

@servzin
Copy link

servzin commented May 25, 2022

The fix from the testing branch worked for me on Pop_OS! 22.04. Thank you @kgilmer for digging down into the issue, I highly appreciate it!

@kgilmer kgilmer added bug Something isn't working and removed help wanted Extra attention is needed labels May 25, 2022
@t3st-account
Copy link

I also can reproduce this issue in Linux Mint 20.3 (based on focal)
the testing branch does not resolve the issue for me

@t3st-account
Copy link

as of regolith-control-center 3.36.5 the bug is fixed on Linux Mint 20.3

kgilmer pushed a commit that referenced this issue Jul 29, 2022
Make sure to keep a reference to the GoaObject of the account around so
that the GBinding that synchronises each switch widget and the account
properties don't get finalized on startup.

 #0  0x00007ffff73c6a20 in g_binding_finalize () at /lib64/libgobject-2.0.so.0
 #1  0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #2  0x00007ffff73c68e8 in weak_unbind () at /lib64/libgobject-2.0.so.0
 #3  0x00007ffff73cf117 in weak_refs_notify () at /lib64/libgobject-2.0.so.0
 #4  0x00007ffff72acd6c in g_data_set_internal () at /lib64/libglib-2.0.so.0
 #5  0x00007ffff73d0195 in g_object_real_dispose.lto_priv () at /lib64/libgobject-2.0.so.0
 #6  0x00007ffff73d3c44 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #7  0x00007ffff72b6793 in g_hash_table_remove_all_nodes.part () at /lib64/libglib-2.0.so.0
 #8  0x00007ffff72ba723 in g_hash_table_unref () at /lib64/libglib-2.0.so.0
 #9  0x00007ffff753403d in g_dbus_object_proxy_finalize () at /lib64/libgio-2.0.so.0
 #10 0x00007ffff73d3d22 in g_object_unref () at /lib64/libgobject-2.0.so.0
 #11 0x0000000000402d08 in glib_autoptr_clear_GoaObject (_ptr=0x5d59f0) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #12 glib_autoptr_cleanup_GoaObject (_ptr=<synthetic pointer>) at /usr/include/goa-1.0/goa/goa-generated.h:3265
 #13 on_application_activate_show_account_cb (application=0x49f2f0, argv=<optimized out>) at ../../../../Projects/jhbuild/gnome-control-center/panels/online-accounts/gnome-control-center-goa-helper.c:360

Closes: #1721
kgilmer pushed a commit that referenced this issue Jul 29, 2022
Otherwise glib will make internal calls before setlocale is called:
** (process:1124144): WARNING **: 10:16:58.983: dcgettext("(null)", "", 5) called before setlocale()

 #0  0x00007ffff7c80f77 in g_logv () at /lib64/libglib-2.0.so.0
 #1  0x00007ffff7c81233 in g_log () at /lib64/libglib-2.0.so.0
 #2  0x00007ffff7fbb6c6 in dcgettext (__domainname=<optimized out>, __msgid=0x7ffff7ce6c5a "", __category=<optimized out>) at ../../../../Projects/jhbuild/gettext-pseudolocale/gettext-pseudolocale.c:194
 #3  0x00007ffff7c6478e in _g_dgettext_should_translate () at /lib64/libglib-2.0.so.0
 #4  0x00007ffff7c6484b in g_dgettext () at /lib64/libglib-2.0.so.0
 #5  0x00007ffff7e98974 in g_application_class_intern_init () at /lib64/libgio-2.0.so.0
 #6  0x00007ffff7d9cfb8 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #7  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #8  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #9  0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
 #10 0x00007ffff7d8671a in g_object_new_valist () at /lib64/libgobject-2.0.so.0
 #11 0x00007ffff7d867fd in g_object_new () at /lib64/libgobject-2.0.so.0
 #12 0x0000000000449bcc in cc_application_new () at ../../../../Projects/jhbuild/gnome-control-center/shell/cc-application.c:294
 #13 0x0000000000448fa6 in main (argc=1, argv=0x7fffffffd138) at ../../../../Projects/jhbuild/gnome-control-center/shell/main.c:55
kgilmer pushed a commit that referenced this issue Nov 28, 2022
Entering the Wi-Fi page without connected to a network trips an
assertion failure:

  (gnome-control-center:14943): nm-CRITICAL **: 16:36:16.732: nm_access_point_get_frequency: assertion 'NM_IS_ACCESS_POINT(ap)' failed

  Thread 1 "gnome-control-c" received signal SIGTRAP, Trace/breakpoint trap.
  0x00007ffff7c8ee51 in g_logv () from /lib64/libglib-2.0.so.0
  (gdb) bt
  #0  0x00007ffff7c8ee51 in g_logv () at /lib64/libglib-2.0.so.0
  #1  0x00007ffff7c8f0d3 in g_log () at /lib64/libglib-2.0.so.0
  #2  0x00007ffff63b7b8a in nm_access_point_get_frequency () at /lib64/libnm.so.0
  #3  0x00000000005965b1 in connect_details_page (self=0x4658210) at ../panels/network/connection-editor/ce-page-details.c:264
  #4  0x0000000000597f9e in ce_page_details_new (connection=0xfbde70, device=0xd52360, ap=0x0, editor=0x50a4350) at ../panels/network/connection-editor/ce-page-details.c:570
  #5  0x0000000000593273 in net_connection_editor_set_connection (self=0x50a4350, connection=0x7fffcc096770) at ../panels/network/connection-editor/net-connection-editor.c:522
  #6  0x0000000000593f7d in net_connection_editor_new (connection=0x7fffcc096770, device=0xd52360, ap=0x0, client=0xd3a0c0) at ../panels/network/connection-editor/net-connection-editor.c:790
  #7  0x0000000000582b16 in show_details_for_row (self=0xcc3040, row=0x46587b0, list=0x4273b40) at ../panels/network/net-device-wifi.c:987
  #8  0x00007ffff7d83845 in g_cclosure_marshal_VOID__OBJECTv () at /lib64/libgobject-2.0.so.0
  #9  0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #10 0x00007ffff7da1eb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
  #11 0x000000000058d41f in on_row_configured_cb (self=0x4273b40, row=0x46587b0) at ../panels/network/cc-wifi-connection-list.c:251
  #12 0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #13 0x00007ffff7da1eb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
  #14 0x000000000058c4c4 in configure_clicked_cb (self=0x46587b0) at ../panels/network/cc-wifi-connection-row.c:513
  #15 0x00007ffff7da1b79 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
  #16 0x00007ffff7da1cb3 in g_signal_emit () at /lib64/libgobject-2.0.so.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants