Skip to content

Commit c9044ba

Browse files
Abseil Teamcopybara-github
Abseil Team
authored andcommitted
Trying to make it more clear: this is probably not about mock classes, but about mocked classes
PiperOrigin-RevId: 439427291 Change-Id: I3cac035e732fb3fe4f9c314657932a55269e0416
1 parent 137f67e commit c9044ba

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docs/gmock_for_dummies.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,12 @@ Some people put it in a `_test.cc`. This is fine when the interface being mocked
190190
`Foo` changes it, your test could break. (You can't really expect `Foo`'s
191191
maintainer to fix every test that uses `Foo`, can you?)
192192

193-
Generally, you should not define mock classes you don't own. If you must mock
194-
such a class owned by others, define the mock class in `Foo`'s Bazel package
195-
(usually the same directory or a `testing` sub-directory), and put it in a `.h`
196-
and a `cc_library` with `testonly=True`. Then everyone can reference them from
197-
their tests. If `Foo` ever changes, there is only one copy of `MockFoo` to
198-
change, and only tests that depend on the changed methods need to be fixed.
193+
Generally, you should not mock classes you don't own. If you must mock such a
194+
class owned by others, define the mock class in `Foo`'s Bazel package (usually
195+
the same directory or a `testing` sub-directory), and put it in a `.h` and a
196+
`cc_library` with `testonly=True`. Then everyone can reference them from their
197+
tests. If `Foo` ever changes, there is only one copy of `MockFoo` to change, and
198+
only tests that depend on the changed methods need to be fixed.
199199

200200
Another way to do it: you can introduce a thin layer `FooAdaptor` on top of
201201
`Foo` and code to this new interface. Since you own `FooAdaptor`, you can absorb

0 commit comments

Comments
 (0)