Skip to content

Commit bba31cd

Browse files
chayimbarshaul
andauthored
Removing distutils from tests (#1773)
Co-authored-by: Bar Shaul <[email protected]>
1 parent 748c8d1 commit bba31cd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/conftest.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import random
22
import time
3-
from distutils.version import LooseVersion
43
from unittest.mock import Mock
54
from urllib.parse import urlparse
65

76
import pytest
7+
from packaging.version import Version
88

99
import redis
1010
from redis.backoff import NoBackoff
@@ -117,13 +117,13 @@ def wait_for_cluster_creation(redis_url, cluster_nodes, timeout=20):
117117

118118
def skip_if_server_version_lt(min_version):
119119
redis_version = REDIS_INFO["version"]
120-
check = LooseVersion(redis_version) < LooseVersion(min_version)
120+
check = Version(redis_version) < Version(min_version)
121121
return pytest.mark.skipif(check, reason=f"Redis version required >= {min_version}")
122122

123123

124124
def skip_if_server_version_gte(min_version):
125125
redis_version = REDIS_INFO["version"]
126-
check = LooseVersion(redis_version) >= LooseVersion(min_version)
126+
check = Version(redis_version) >= Version(min_version)
127127
return pytest.mark.skipif(check, reason=f"Redis version required < {min_version}")
128128

129129

@@ -331,7 +331,7 @@ def wait_for_command(client, monitor, command, key=None):
331331
if key is None:
332332
# generate key
333333
redis_version = REDIS_INFO["version"]
334-
if LooseVersion(redis_version) >= LooseVersion("5.0.0"):
334+
if Version(redis_version) >= Version("5.0.0"):
335335
id_str = str(client.client_id())
336336
else:
337337
id_str = f"{random.randrange(2 ** 32):08x}"

tests/test_search.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ def test_profile(client):
14191419
assert det["Iterators profile"]["Counter"] == 2.0
14201420
assert len(det["Iterators profile"]["Child iterators"]) == 2
14211421
assert det["Iterators profile"]["Type"] == "UNION"
1422-
assert det["Parsing time"] < 0.3
1422+
assert det["Parsing time"] < 0.5
14231423
assert len(res.docs) == 2 # check also the search result
14241424

14251425
# check using AggregateRequest
@@ -1431,7 +1431,7 @@ def test_profile(client):
14311431
res, det = client.ft().profile(req)
14321432
assert det["Iterators profile"]["Counter"] == 2.0
14331433
assert det["Iterators profile"]["Type"] == "WILDCARD"
1434-
assert det["Parsing time"] < 0.3
1434+
assert det["Parsing time"] < 0.5
14351435
assert len(res.rows) == 2 # check also the search result
14361436

14371437

0 commit comments

Comments
 (0)