Skip to content

Commit 804fe24

Browse files
committed
Remove Omit and replace size with $size; make src and alt required
1 parent cf0fbcd commit 804fe24

File tree

5 files changed

+10
-14
lines changed

5 files changed

+10
-14
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import React from 'react'
22
import { RiImageProps, StyledImage } from './image.styles'
33

4-
const RiImage = ({ size, src, alt, ...rest }: RiImageProps) => (
5-
<StyledImage src={src} alt={alt} size={size} {...rest} />
4+
const RiImage = ({ $size, src, alt, ...rest }: RiImageProps) => (
5+
<StyledImage src={src} alt={alt} $size={$size} {...rest} />
66
)
77

88
export default RiImage

redisinsight/ui/src/components/base/display/image/image.styles.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,11 @@ export const imageSizeStyles = {
2727
export type RiImageSize = (typeof SIZES)[number]
2828

2929
export interface RiImageProps extends HTMLAttributes<HTMLImageElement> {
30-
size?: RiImageSize
31-
src?: string
32-
alt?: string
30+
$size?: RiImageSize
31+
src: string
32+
alt: string
3333
}
3434

35-
export const StyledImage = styled.img<
36-
Omit<RiImageProps, 'size'> & {
37-
size?: RiImageSize
38-
}
39-
>`
40-
${({ size = 'original' }) => imageSizeStyles[size]}
35+
export const StyledImage = styled.img<RiImageProps>`
36+
${({ $size = 'original' }) => imageSizeStyles[$size]}
4137
`

redisinsight/ui/src/components/oauth/oauth-sign-in-button/OAuthSignInButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const OAuthSignInButton = (props: Props) => {
2929
}
3030
data-testid="cloud-sign-in-btn"
3131
>
32-
<RiImage className={styles.logo} src={RedisLogo} alt="" />
32+
<RiImage className={styles.logo} src={RedisLogo} alt="Redis logo" />
3333
<span>Cloud sign in</span>
3434
</SecondaryButton>
3535
)}

redisinsight/ui/src/components/oauth/shared/oauth-advantages/OAuthAdvantages.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import styles from './styles.module.scss'
1010

1111
const OAuthAdvantages = () => (
1212
<div className={styles.container} data-testid="oauth-advantages">
13-
<RiImage className={styles.logo} src={RedisLogo} alt="" />
13+
<RiImage className={styles.logo} src={RedisLogo} alt="Redis logo" />
1414
<Title size="S" className={styles.title}>
1515
Cloud
1616
</Title>

redisinsight/ui/src/pages/rdi/statistics/empty/Empty.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const Empty = ({ rdiInstanceId }: Props) => {
2121
return (
2222
<Panel>
2323
<div className={styles.emptyPipelineContainer} data-testid="empty-pipeline">
24-
<RiImage src={EmptyPipelineIcon} alt="empty" size="s" />
24+
<RiImage src={EmptyPipelineIcon} alt="empty" $size="s" />
2525
<Spacer size="xl" />
2626
<Text>No pipeline deployed yet</Text>
2727
<Text className={styles.subTitle}>

0 commit comments

Comments
 (0)