Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing task - Create disk #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add missing task - Create disk #169

wants to merge 2 commits into from

Conversation

sousinha97
Copy link
Contributor

Description

Add missing task for GCP disk creation

@sousinha97 sousinha97 self-assigned this Feb 11, 2025
@sousinha97 sousinha97 requested a review from a team February 11, 2025 12:56
name: tf_create
vars:
tf_var_file: "env.tfvars"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigate disk creation, document anything that deviates from AWS/Azure on disk creation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sousinha97 sousinha97 linked an issue Feb 18, 2025 that may be closed by this pull request
@sousinha97 sousinha97 added pr_review [Automatic Label] Issue has a PR that needs review bug Something isn't working labels Feb 18, 2025
@sousinha97 sousinha97 linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link
Contributor

@dvalinrh dvalinrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvalinrh dvalinrh added group_review_lgtm Indicates approval after a group review meeting and removed bug Something isn't working pr_review [Automatic Label] Issue has a PR that needs review labels Feb 18, 2025
@kdvalin
Copy link
Member

kdvalin commented Feb 25, 2025

Please reference the issue this PR is going to fix in the description. Also add the Jira Ticket number in this format Relates to JIRA: RPOPC-<NUMBER>. Workflows will block merge until this is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group_review_lgtm Indicates approval after a group review meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach disk option for GCP
4 participants