Updates to verification code based on actual usage. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalinrh
changed the title
dvalinrh
commented
Feb 25, 2025
| diff $verify_res_before $verify_res_after | ||
| base_res_file=`ls $vdir/$test_base_results/*csv` | ||
| if [[ $? -ne 0 ]]; then | ||
| echo "Error, did not find a csv file in $vdir/$test_base_results" |
There was a problem hiding this comment.
Error out condition required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The verification code needs to figure out the proper path to the file is
There are two options
Before/After Comparison
Before we would need to provide the absolute path at all times. This will cause issues with running the verification tests from zathras.
After:
We now just have to point to the test results from where it is, relative to the git repo
Clerical Stuff
This closes #52
Relates to JIRA: RPOPC-345