Fix missing metadata header. #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frival
reviewed
Feb 18, 2025
frival
requested changes
Feb 18, 2025
|
Comment section above fixed. |
dvalinrh
commented
Feb 25, 2025
speccpu2017/run_speccpu
Outdated
| @@ -232,7 +232,7 @@ done | |||
| # clone the repo. | |||
| # | |||
| if [ ! -d "test_tools" ]; then | |||
| git clone $tools_git ${curdir}/test_tools | |||
| git clone $tools_git test_tools | |||
There was a problem hiding this comment.
Wrong, use $curdir not pwd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It places the system metadata in the csv results file, currently missing
Before/After Comparison
Before change:
Benchmarks:Base copies:Base Run Time:Base Rate
500.perlbench_r:4:475:13.4
502.gcc_r:4:346:16.4
505.mcf_r:4:396:16.3
520.omnetpp_r:4:668:7.85
After change
# Test general meta start
# Test: speccpu2017
# Results version: 118
# Host: m6a.xlarge
# Sys environ: aws
# Tuned: virtual-guest
# OS: 5.14.0-362.18.1.el9_3.x86_64
# Numa nodes: 1
# CPU family: AMD EPYC 7R13 Processor
# Number cpus: 4
# Memory: 15720220kB
# Test general meta end
Benchmarks:Base copies:Base Run Time:Base Rate
500.perlbench_r:4:475:13.4
502.gcc_r:4:346:16.4
505.mcf_r:4:396:16.3
520.omnetpp_r:4:668:7.85
Clerical Stuff
This closes Issue #29
Relates to JIRA: RPOPC-<TICKET_NUMBER>