Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously released hosts appear to be touched after expansion - validate traceback #572

Open
kambiz-aghaiepour opened this issue Feb 12, 2025 · 0 comments

Comments

@kambiz-aghaiepour
Copy link
Contributor

Version: quads-2.1.6-20250210.noarch

An existing environment previously released was expanded with additional hosts. I was expecting that the subsequent validation would only encompass the expansion hosts, and not the previous hosts. However, after adding expansion hosts to an existing environment, I noticed the following in the validation log (after the expansion hosts were successfully provisioned):

Validating cloud38
The following hosts appear to be down or with no ssh connection:
e26-h17-000-r640.example.com
e30-h01-000-r640.example.com
e30-h02-000-r640.example.com
e30-h03-000-r640.example.com
e30-h05-000-r640.example.com
e30-h07-000-r640.example.com
e30-h09-000-r640.example.com
e30-h10-000-r640.example.com
e30-h11-000-r640.example.com
e30-h13-000-r640.example.com
e30-h14-000-r640.example.com
e30-h17-000-r640.example.com
e30-h18-000-r640.example.com
e30-h19-000-r640.example.com
e30-h21-000-r640.example.com
Quads assignments validation executed.

Note that the hosts shown in the validation log were not the expansion hosts, but rather the existing hosts that had already passed validation when the environment first went out. Furthermore, the hosts (that start with e30) had their switch configs modified (intentionally) to be on the same network as a different environment, using the modify_switch_conf.py command. This modified network membership we reverted when the environment expansion decided to touch the pre-existing hosts.

It's not clear if the hosts were properly marked as validated from the previous release.

The docs also indicate that I can skip specific hosts during validation by running the following as per: https://github.com/redhat-performance/quads/tree/latest?tab=readme-ov-file#skipping-past-network-and-systems-validation-per-host

# python3 /usr/lib/python3.12/site-packages/quads/tools/validate_env.py --skip-hosts e26-h17-000-r640.example.com e30-h01-000-r640.example.com e30-h02-000-r640.example.com e30-h03-000-r640.example.com e30-h05-000-r640.example.com e30-h07-000-r640.example.com e30-h09-000-r640.example.com e30-h10-000-r640.example.com e30-h11-000-r640.example.com e30-h13-000-r640.example.com e30-h14-000-r640.example.com e30-h17-000-r640.example.com e30-h18-000-r640.example.com e30-h19-000-r640.example.com e30-h21-000-r640.example.com
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/quads/tools/validate_env.py", line 452, in <module>
    loop_main.run_until_complete(main(args))
  File "/usr/lib64/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/quads/tools/validate_env.py", line 395, in main
    host = quads.get_host(hostname)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/quads/quads_api.py", line 142, in get_host
    response = self.get(os.path.join("hosts", hostname))
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 90, in join
  File "<frozen genericpath>", line 164, in _check_arg_types
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'list'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants