feat: centralize namespace configuration for RHDH CI/CD jobs #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gustavolira
force-pushed
the
RHIDP-9868
branch
from
19bdb33 to
1abe189
Compare
Contributor
|
The image is available at: |
gustavolira
force-pushed
the
RHIDP-9868
branch
from
1abe189 to
c35d735
Compare
This commit introduces a new centralized namespace configuration file, `.ibm/pipelines/namespace-config.sh`, which standardizes namespace definitions across various job handlers. All job scripts now source this configuration and utilize the `set_namespaces()` function to dynamically set namespaces based on the `JOB_NAME` environment variable. This change enhances maintainability, consistency, and visibility of namespace management within the RHDH codebase.
gustavolira
force-pushed
the
RHIDP-9868
branch
from
c35d735 to
e10993c
Compare
|
Member
Author
|
/test e2e-ocp-helm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces a new centralized namespace configuration file,
.ibm/pipelines/namespace-config.sh, which standardizes namespace definitions across various job handlers. All job scripts now source this configuration and utilize theset_namespaces()function to dynamically set namespaces based on theJOB_NAMEenvironment variable. This change enhances maintainability, consistency, and visibility of namespace management within the RHDH codebase.Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer