-
Notifications
You must be signed in to change notification settings - Fork 34
fix(tests): changed the expexted format of the config files #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfestal
reviewed
Nov 22, 2025
8ad1298 to
db92b48
Compare
davidfestal
requested changes
Nov 24, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need to install yq with:
- name: Setup yq
uses: mikefarah/yq@v4knowing that it is included by default in the ubuntu runner (afaict) ?
e1e2dd0 to
fc9c501
Compare
davidfestal
reviewed
Nov 26, 2025
Signed-off-by: rostalan <[email protected]>
fc9c501 to
ac2f91b
Compare
davidfestal
approved these changes
Nov 26, 2025
Contributor
Author
|
/publish |
Contributor
|
PR action ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspaces/<workspace_name>/metadata/<plugin_name>.yamlfile format.workspaces/<workspace_name>/tests/test.env) checks, it passes if the file is found and contains all needed vars, skips when no file is found and required and fails if any of the required vars are missing.README.md