LanguageServerLifecycleListener is internal now

[onriv]

Hi! I find that now LanguageServerLifecycleListener is marked as internal, I override this class for some enhancement for the server like request context management (ref). What is supposed way for the replacement of overriding this class?
Thanks!

[angelozerr]

This listener is internal because I don't want to expose LanguageServerWrapper since API changes every time.

Today the proper API is LSPClientFeatures https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPApi.md

Please try it and if you need some API improvement please create issues.

[onriv]

Thanks! Yeah let me try if I can remove it via using LSPClientFeatures

[angelozerr]

You are welcome!

To be honnest with you I dont understand very well why you need to delegate some lsp message to your service class.

My first impression is that you are tweaking lsp4ij to have some custom behavior or perhaps fixing bugs from lsp4ij ?

If it that please create several issues to provide the expected behaviour that you wish or fix some bugs

IMHO you should avoid using your service class but perhaps I am wrong.

[onriv]

Currently I am mainly using it for the following three reasons. I think reason 1 and reason 3 is critical for using the listener.

1. Highlighting the hover range. For this purpose I am checking if the result is a hover object from the lsp response. If so, I am creating munually a highlight range:

2. For implementing a customized vertical status bar. For this I need to know when the language server starts. I think this is unnecessary to use the listener too though. 3. For showing some information from `textDocument/publishDiagnostics` to a dedicated tool window:

[onriv]

BTW I am trying to temporally proxy the listener (ref) for I have a long time no working on the lean4ij plugin and I am trying to see if I can release a new version or not. I agree that LanguageServerLifecycleListener should be internal too but currently may I dont have enough time to remove it but still keep the above features yet. I am sorry for using the proxy.

[angelozerr]

Highlighting the hover range. For this purpose I am checking if the result is a hover object from the lsp response. If so, I am creating munually a highlight range:

IntelliJ cannot manage that? I think it is a nice feature and LSP4IJ should handle this feature (that we could disable with LSPHoverFeatures).

implementing a customized vertical status bar. For this I need to know when the language server starts. I think this is unnecessary to use the listener too though.

I suggest that you use LSPClientFeatures#handleServerStatusChanged(@NotNull ServerStatus serverStatus)

For showing some information from textDocument/publishDiagnostics to a dedicated tool window:

LSP4IJ could send to a notification bus those PublishDiagnostics, what do you think about that?

[onriv]

Yeah Intellij cannot handle the hover highlights. There are something different about leanij's hover highlight logic. Since lean is a formal theorm proof assistant, the language server highlights an appropriate range but not only the current hovering token. For example for (1 + 2) * 3 hovering on * it highlights the full expression and hovering on + it highlights only the sub expression. The range for highlighting can only be received from the language server.

I think lsp4ij can add a feature for the hovering highlights too! But the highlight style related to theme dynamically updating, would it be a little complicated for lsp4ij?

Yeah I will try the status update with the new handleServerStatusChanged method.

I think a dedicated notification bus for textDocument/publishDiagnostics is enough for my case too!