Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checking of mandatory fields in pubsub #113

Merged
merged 1 commit into from
Dec 20, 2024
Merged

add checking of mandatory fields in pubsub #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/pubsub/pubsub_unmarshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package pubsub

import (
"fmt"
"io"
"sync"

Expand Down Expand Up @@ -91,7 +92,14 @@ func readJSONFromIterator(out *PubSub, iterator *jsoniter.Iterator) error {
if iterator.Error != nil {
return iterator.Error
}

// Skip checking EndPointURI here since it is not used in http transport.
// Check EndPointURI in O-RAN REST API handler
//if endpointUri == "" {
// return fmt.Errorf("mandatory field EndPointURI is not set")
//}
if resource == "" {
return fmt.Errorf("mandatory field ResourceAddress is not set")
}
out.SetID(id)
out.SetEndpointURI(endpointUri) //nolint:errcheck
out.SetURILocation(uriLocation) //nolint:errcheck
Expand Down