Merge pull request #93 from reddit/debug_log_feature_not_found

Log 'feature not found' to debug logger

Author: mrlevitas

reddit_decider/__init__.py

@@ -1,5 +1,4 @@
 import logging
-import warnings
 
 from copy import deepcopy
 from dataclasses import dataclass
@@ -375,7 +374,7 @@ def expose(
         try:
             feature = self._internal.get_feature(experiment_name)
         except FeatureNotFoundException as exc:
-            warnings.warn(str(exc))
+            logger.debug(str(exc))
             return
         except DeciderException as exc:
             logger.info(str(exc))
@@ -772,7 +771,7 @@ def _get_decision(
         try:
             return self._internal.choose(experiment_name, ctx)
         except FeatureNotFoundException as exc:
-            warnings.warn(str(exc))
+            logger.debug(str(exc))
             return None
         except DeciderException as exc:
             logger.info(str(exc))
@@ -807,7 +806,7 @@ def _get_dynamic_config_value(
         try:
             value = get_fn(feature_name=feature_name, context=ctx)
         except FeatureNotFoundException as exc:
-            warnings.warn(str(exc))
+            logger.debug(str(exc))
             return default
         except ValueTypeMismatchException as exc:
             logger.info(str(exc))
@@ -844,7 +843,7 @@ def get_experiment(self, experiment_name: str) -> Optional[ExperimentConfig]:
         try:
             feature = self._internal.get_feature(experiment_name)
         except FeatureNotFoundException as exc:
-            warnings.warn(str(exc))
+            logger.debug(str(exc))
             return None
         except DeciderException as exc:
             logger.info(str(exc))

tests/decider_tests.py

@@ -562,13 +562,12 @@ def test_none_returned_on_get_variant_call_with_experiment_not_found(self):
             )
 
             self.assertEqual(self.event_logger.log.call_count, 0)
-            with warnings.catch_warnings(record=True) as captured:
+            with self.assertLogs(logger, logging.DEBUG) as captured:
                 variant = decider.get_variant("anything")
 
-                # can't test warning log only shows up only once if `decider.get_variant("anything")`
-                # is called again due to bug in `catch_warnings` contextmanager
-                # see https://github.com/python/cpython/issues/73858
-                assert any('Feature "anything" not found.' in str(x.message) for x in captured)
+                assert any(
+                    'Feature "anything" not found.' in x.getMessage() for x in captured.records
+                )
             self.assertEqual(variant, None)
 
             # no exposures should be triggered
@@ -613,13 +612,12 @@ def test_none_returned_on_get_variant_without_expose_call_with_experiment_not_fo
             )
 
             self.assertEqual(self.event_logger.log.call_count, 0)
-            with warnings.catch_warnings(record=True) as captured:
+            with self.assertLogs(logger, logging.DEBUG) as captured:
                 variant = decider.get_variant_without_expose("anything")
 
-                # can't test warning log only shows up only once if `decider.get_variant("anything")`
-                # is called again due to bug in `catch_warnings` contextmanager
-                # see https://github.com/python/cpython/issues/73858
-                assert any('Feature "anything" not found.' in str(x.message) for x in captured)
+                assert any(
+                    'Feature "anything" not found.' in x.getMessage() for x in captured.records
+                )
             self.assertEqual(variant, None)
 
             # no exposures should be triggered