Skip to content

Commit 938148d

Browse files
authored
Merge pull request #86 from reddit/add_emit_event_field_to_ExperimentConfig
Add `emit_event` field to `get_experiment()` return `ExperimentConfig`
2 parents 5411839 + 0eda5e1 commit 938148d

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

reddit_decider/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ class ExperimentConfig:
4949
start_ts: int
5050
stop_ts: int
5151
owner: str
52+
emit_event: Optional[bool] = None
5253

5354

5455
class DeciderContext:
@@ -890,6 +891,7 @@ def get_experiment(self, experiment_name: str) -> Optional[ExperimentConfig]:
890891
start_ts=exp_dict.get("variant_set", {}).get("start_ts"),
891892
stop_ts=exp_dict.get("variant_set", {}).get("stop_ts"),
892893
owner=exp_dict.get("owner"),
894+
emit_event=bool(exp_dict.get("emit_event")),
893895
)
894896

895897

tests/decider_tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1313,6 +1313,7 @@ def test_get_experiment(self):
13131313
self.assertEqual(experiment.start_ts, cfg["start_ts"])
13141314
self.assertEqual(experiment.stop_ts, cfg["stop_ts"])
13151315
self.assertEqual(experiment.owner, cfg["owner"])
1316+
self.assertEqual(experiment.emit_event, True)
13161317

13171318
def test_get_variant_without_expose_with_HG_as_control_1_and_child_returns_none_does_expose(
13181319
self,

0 commit comments

Comments
 (0)