Skip to content

Commit 8aaaed6

Browse files
authored
Merge pull request #6 from reddit/dynamic_config
Decider
2 parents 4f58f49 + 4f277a9 commit 8aaaed6

File tree

9 files changed

+654
-13
lines changed

9 files changed

+654
-13
lines changed

.dockerignore

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,5 @@ __pycache__/
88
/.dockerignore
99
/.git
1010
/Dockerfile
11-
/tests/range_variant_tests/data/original_zk_config.json
12-
/tests/range_variant_tests/data/range_variant_zk_config.json
13-
/tests/range_variant_tests/data/output.json
11+
/tests/range_variant_tests/data/*
1412
venv*

.github/workflows/python-package.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ jobs:
1111

1212
runs-on: ubuntu-latest
1313
strategy:
14+
fail-fast: false
1415
matrix:
15-
python-version: [3.7, 3.8, 3.9]
16+
python-version: ['3.7', '3.8', '3.9', '3.10']
1617

1718
steps:
1819
- uses: actions/checkout@v2
@@ -35,7 +36,7 @@ jobs:
3536
3637
- name: Lint
3738
run: |
38-
make lint
39+
make lint PYTHON_VERSION=${{ matrix.python-version }}
3940
4041
- name: Test
4142
run: |

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.8
1+
FROM python:3.9
22

33
WORKDIR /src
44
COPY requirements*.txt .

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
SOURCE_ROOT := reddit_experiments/
2-
PYTHON_SOURCE = $(shell find $(SOURCE_ROOT) tests/ setup.py -name '*.py')
2+
PYTHON_SOURCE = $($(shell) find $(SOURCE_ROOT) tests/ setup.py -name '*.py')
33
REORDER_PYTHON_IMPORTS := reorder-python-imports --py3-plus --separate-from-import --separate-relative
4-
4+
PYTHON_VERSION ?= 3.9
55

66
.PHONY: fmt
77
fmt:
@@ -14,7 +14,7 @@ lint:
1414
$(REORDER_PYTHON_IMPORTS) --diff-only $(PYTHON_SOURCE)
1515
black --diff --check $(PYTHON_SOURCE)
1616
flake8 $(SOURCE_ROOT)
17-
mypy $(SOURCE_ROOT)
17+
mypy $(SOURCE_ROOT) --python-version $(PYTHON_VERSION)
1818

1919
.PHONY: test
2020
test:

0 commit comments

Comments
 (0)