lint reddit_experiments

Author: mrlevitas

Makefile

@@ -1,5 +1,5 @@
-SOURCE_ROOT := reddit_experiments/
-PYTHON_SOURCE = $($(shell) find $(SOURCE_ROOT) tests/ setup.py -name '*.py')
+SOURCE_ROOT := reddit_experiments/ reddit_decider/
+PYTHON_SOURCE = $(shell find $(SOURCE_ROOT) tests/ setup.py -name '*.py')
 REORDER_PYTHON_IMPORTS := reorder-python-imports --py3-plus --separate-from-import --separate-relative
 PYTHON_VERSION ?= 3.9
 

reddit_decider/__init__.py

@@ -2,8 +2,13 @@
 
 from dataclasses import dataclass
 from enum import Enum
-from typing import Any, Callable, Dict, IO, Optional
-from typing_extensions import Literal
+from typing import Any
+from typing import Callable
+from typing import Dict
+from typing import IO
+from typing import Optional
+
+import rust_decider
 
 from baseplate import RequestContext
 from baseplate import Span
@@ -15,8 +20,8 @@
 from baseplate.lib.file_watcher import T
 from baseplate.lib.file_watcher import WatchedFileNotAvailableError
 from reddit_edgecontext import ValidatedAuthenticationToken
+from typing_extensions import Literal
 
-import rust_decider
 
 
 logger = logging.getLogger(__name__)

reddit_experiments/__init__.py

@@ -18,7 +18,6 @@
 from baseplate.lib.file_watcher import FileWatcher
 from baseplate.lib.file_watcher import WatchedFileNotAvailableError
 from reddit_edgecontext import User
-
 from reddit_experiments.providers import parse_experiment
 from reddit_experiments.providers.base import Experiment
 

reddit_experiments/providers/__init__.py

@@ -5,7 +5,6 @@
 from typing import Dict
 
 from baseplate.lib import warn_deprecated
-
 from reddit_experiments.providers.base import Experiment
 from reddit_experiments.providers.feature_flag import FeatureFlag
 from reddit_experiments.providers.forced_variant import ForcedVariantExperiment
@@ -25,9 +24,7 @@
     ["single_variant", "multi_variant", "feature_rollout", "range_variant"]
 )
 
-new_exp_type_list = frozenset(
-    ["dynamic_config"]
-)
+new_exp_type_list = frozenset(["dynamic_config"])
 
 
 def parse_experiment(config: Dict[str, str]) -> Experiment:

setup.py

@@ -16,7 +16,11 @@
     packages=find_packages(),
     python_requires=">=3.7",
     setup_requires=["setuptools_scm"],
-    install_requires=["baseplate>=2.0.0a1,<3.0", "reddit-edgecontext>=1.0.0a3,<2.0", "reddit-decider>=1.1.11"],
+    install_requires=[
+        "baseplate>=2.0.0a1,<3.0",
+        "reddit-edgecontext>=1.0.0a3,<2.0",
+        "reddit-decider>=1.1.11",
+    ],
     package_data={"reddit_experiments": ["py.typed"]},
     zip_safe=True,
     classifiers=[

tests/decider_tests.py

@@ -11,14 +11,14 @@
 from baseplate.lib.file_watcher import FileWatcher
 from reddit_edgecontext import AuthenticationToken
 from reddit_edgecontext import User
-
-from reddit_decider import DeciderContextFactory
-from reddit_decider import init_decider_parser
 from reddit_experiments import EventType
 from reddit_experiments import Experiments
 from reddit_experiments import experiments_client_from_config
 from reddit_experiments import ExperimentsContextFactory
 
+from reddit_decider import DeciderContextFactory
+from reddit_decider import init_decider_parser
+
 
 THIRTY_DAYS = timedelta(days=30).total_seconds()
 

tests/experiment_tests.py

@@ -9,7 +9,6 @@
 from baseplate import ServerSpan
 from baseplate.lib.events import EventQueue
 from baseplate.lib.file_watcher import FileWatcher
-
 from reddit_experiments import Experiments
 from reddit_experiments.providers import parse_experiment
 

tests/providers/feature_flag_tests.py

@@ -10,7 +10,6 @@
 from baseplate import ServerSpan
 from baseplate.lib.events import EventLogger
 from baseplate.lib.file_watcher import FileWatcher
-
 from reddit_experiments import ExperimentsContextFactory
 from reddit_experiments.providers import parse_experiment
 from reddit_experiments.providers.r2 import R2Experiment

tests/providers/r2_tests.py

@@ -7,7 +7,6 @@
 from baseplate.lib.file_watcher import FileWatcher
 from reddit_edgecontext import AuthenticationToken
 from reddit_edgecontext import User
-
 from reddit_experiments import Experiments
 
 ORIGINAL_ZK_CONFIG_FILE = "tests/range_variant_tests/data/original_zk_config.json"