Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new sass library instead of node-sass #1652

Closed
gagik opened this issue Jun 6, 2024 · 2 comments · Fixed by #1654
Closed

Use the new sass library instead of node-sass #1652

gagik opened this issue Jun 6, 2024 · 2 comments · Fixed by #1654
Assignees

Comments

@gagik
Copy link
Collaborator

gagik commented Jun 6, 2024

Is your feature request related to a problem? Please describe.
CI seems to have updated to python 3.12 by default. node-sass is deprecated and was breaking CI lint because one of its dependencies was using a python standard library which was removed in 3.12: nodejs/node-gyp#2869. Right now the issue is "fixed" by setting our Python version to 3.11 but it'd be good to have latest sass installed which removes the need for this.

sass will also help us ensure better compatibility with the arm64 runner.

Describe the solution you'd like

  1. Remove node-sass.
  2. Remove the Setup Python 3.11 from the linting GitHub Actions workflow.
  3. Add sass as a dependency.
  4. Fix sass warnings we have in our repository (mainly related to deprecated SASS properties).

Describe alternatives you've considered
We can also just continue using node-sass and Python 3.11 or wait for a potential update of the library.

Additional context
See #1651

Copy link

sync-by-unito bot commented Jun 6, 2024

➤ PM Bot commented:

Jira ticket: RSTUDIO-538

@kraenhansen
Copy link
Member

kraenhansen commented Jun 6, 2024

As discussed elsewhere, this is probably caused by sass/node-sass#3033 since the macos-latest runner on GHA is now arm64.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants