Install python through UV and other feedback

- Fix the docs makefile
- Document pre-commit

Author: davidfischer

docker-compose/django/Dockerfile

@@ -10,7 +10,6 @@ ENV PYTHONUNBUFFERED 1
 # Copy (don't hardlink) files into /.venv. Avoid issues with Docker's FS
 # https://docs.astral.sh/uv/reference/environment/
 ENV UV_LINK_MODE=copy
-ENV UV_PYTHON_DOWNLOADS=never
 ENV UV_PROJECT_ENVIRONMENT=/.venv
 
 
@@ -25,8 +24,6 @@ RUN apt-get -y install \
         libxslt1-dev \
         locales \
         build-essential \
-        python3-pip \
-        python3-dev \
         postgresql-client \
         libmysqlclient-dev \
         libfreetype6 \
@@ -46,6 +43,10 @@ ENV PATH="/root/.local/bin/:$PATH"
 # uv.lock ensures reproducible builds
 COPY pyproject.toml uv.lock ./
 
+# Install Python through uv
+# Get the version pinned by pyproject.toml
+RUN uv python install
+
 # Install dependencies using uv sync
 # This creates a virtual environment at /.venv (not in /app)
 # This installs all dependencies from uv.lock, ensuring consistency

docs/Makefile

@@ -10,14 +10,14 @@ BUILDDIR      = _build
 
 # Put it first so that "make" without argument is like "make help".
 help:
-	@$(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
+	@uv run $(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
 
 livehtml:
-	sphinx-autobuild -b html --port 4444 $(SPHINXOPTS) $(SOURCEDIR) $(BUILDDIR)/html
+	@uv run sphinx-autobuild -b html --port 4444 $(SPHINXOPTS) $(SOURCEDIR) $(BUILDDIR)/html
 
 .PHONY: help livehtml Makefile
 
 # Catch-all target: route all unknown targets to Sphinx using the new
 # "make mode" option.  $(O) is meant as a shortcut for $(SPHINXOPTS).
 %: Makefile
-	@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
+	@uv run $(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)

docs/developer/quickstart.rst

@@ -20,76 +20,75 @@ Start a local multi-container application with Postgres, Redis, Celery, and Djan
 
     $ make dockerserve
 
-To get a shell into the Django container where you can run ``./manage.py createsuperuser``,
+To get a shell into the Django container where you can run ``uv run ./manage.py createsuperuser``,
 get a Django shell, or run other commands:
 
 .. code-block:: bash
 
     $ make dockershell
     ...
-    /app # ./manage.py createsuperuser
+    /app    # uv run ./manage.py createsuperuser
 
 After setting up your super user account on your local development instance,
 you'll still need to set the :ref:`install/installation:Set the ad server URL`
 to something like ``localhost:5000``.
 
 
-Developing locally
-------------------
+Development tips
+----------------
 
 Docker compose is the recommended way to do development consistently.
-This section is more to document steps than to encourage you to develop outside of Docker.
+This step documents commands for code style, building static assets, and more.
+These commands can be run inside Docker (``make dockershell``).
 
 Requirements
 ~~~~~~~~~~~~
 
-- Python 3.12
+- `uv <https://docs.astral.sh/uv/getting-started/installation/>`_
 - Nodejs (tested with v20)
 
-Front-end assets
-~~~~~~~~~~~~~~~~
 
-To build the assets::
+Managing the ad server and setup
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-    $ npm clean-install
-    $ npm run build
-
-Install Python dependencies
-~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-First, install uv if you haven't already:
+Run migrations:
 
 .. code-block:: bash
 
-   $ curl -LsSf https://astral.sh/uv/install.sh | sh
+    $ uv run ./manage.py migrate
 
-Then install dependencies:
+Create a superuser:
 
 .. code-block:: bash
 
-   $ uv sync --all-extras           # Install all dependencies including dev tools
-   $ uv run pre-commit install      # Install a code style pre-commit hook
+    $ uv run ./manage.py createsuperuser
 
-Run the server
-~~~~~~~~~~~~~~
+Front-end assets
+~~~~~~~~~~~~~~~~
 
-Run migrations:
+To build the assets::
 
 .. code-block:: bash
 
-   $ uv run ./manage.py migrate
+    $ npm clean-install
+    $ npm run build
 
-Create a superuser:
+Pre-commit and code style
+~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Setup pre-commit:
 
 .. code-block:: bash
 
-   $ uv run ./manage.py createsuperuser
+    $ uv tool install pre-commit --with pre-commit-uv
+    $ uvx pre-commit install         # Install a code style pre-commit hook
 
-Run the server:
+You can run all code style checks with teh following:
 
 .. code-block:: bash
 
-   $ uv run ./manage.py runserver
+    $ uvx pre-commit run --all-files
+
 
 Running the tests
 -----------------
@@ -105,4 +104,4 @@ Run a specific test:
 
 .. code-block:: bash
 
-   $ tox -e py3 -- adserver/auth/tests.py
+    $ tox -e py3 -- adserver/auth/tests.py