-
Notifications
You must be signed in to change notification settings - Fork 17
Flyout: convert current flyout to web component #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is an initial implementation for this at #66. However, it changes the design and we don't want that for this initial iteration. |
Take into account these PRs when working on this issue (cc @zanderle): |
It would be great if you could keep the CSS class names and the HTML structure the same, because several Sphinx themes customize the RTD flyout. https://insipid-sphinx-theme.readthedocs.io/en/0.4.2/ If you plan on changing the HTML structure fundamentally, it would be great if you could use a completely new set of CSS classes, because otherwise differentiating between the old and new versions would be very hard. If you need testing, I'm volunteering for testing it with the |
@mgeier We are re-designing the flyout completely using web components in an isolated way. It will be contained on a shadow DOM without the ability to customize it with regular CSS classes or Javascript modifications. Instead, we will be exposing a supported API to perform customization in a controlled way. See
Thanks, we will definitely need help for this. We are not there just yet, tho. The first implementation won't allow customization at all because we want to start testing it in a controlled way initially while we slowly roll it out. Once we are happy with the implementation, we will implement and expose the issues I liked in the previous paragraph. While working on those issues, talking to theme authors and users will be incredibly helpful for us so we can design and pattern that works for everybody. |
Building on top of the work started in #66 Closes #70 --------- Co-authored-by: Manuel Kaufmann <[email protected]>
As the first step, we want to copy the current flyout code and and convert it into a web component. It should work in the exact same way as the one generated by the current JS code and HTML returned by the endpoint.
It has to be floating at the bottom right for the first iteration.
This will allow us to start slowly migrating new projects to use the new flyout, and expose the other addons.
The text was updated successfully, but these errors were encountered: