Skip to content

Notifications: use heiristic to add the notification inline #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Feb 20, 2025 · 2 comments
Closed

Notifications: use heiristic to add the notification inline #550

humitos opened this issue Feb 20, 2025 · 2 comments
Assignees
@humitos

Comments

@humitos
Copy link
Member

humitos commented Feb 20, 2025

We should be able to DocumentationTool class to detect what's the HTML generator and use specific CSS selectors to inject the notification in the document with inline-block position so it doesn't cover any content.

Image
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 20, 2025
humitos added a commit that referenced this issue Feb 20, 2025
@humitos
Notification: render it inline using docTool.getRootSelector()
398478a 
Instead of rendering the notification floating at the top right, we use the
heuristic from `DocumentationTool` class to get the root selector and we prepend
the notification WebComponent there.

Closes #550
@humitos humitos mentioned this issue Feb 20, 2025
Closed
4 tasks
@humitos humitos moved this from Planned to In progress in 📍Roadmap Feb 20, 2025
@humitos humitos self-assigned this Feb 26, 2025
@agjohnson
Copy link
Contributor

The work around a central UI for flyout/notifications etc would supersede this work so we'll come back to this if it is something we want.

@humitos
Copy link
Member Author

humitos commented Apr 10, 2025

Yes. I "created an issue to create issues" for the required work. I'm linking it here, so we have all of these issues backlinked somewhere.

I'm closing this one for now since it doesn't make too much sense to move forward with this approach without further discussion and experiment with the new UI.

@humitos humitos closed this as completed Apr 10, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in 📍Roadmap Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
None yet
Projects
📍Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification: render it inline using docTool.getRootSelector() readthedocs/addons
2 participants
@humitos @agjohnson