-
Notifications
You must be signed in to change notification settings - Fork 15
feat(mdxish): add new MDXish engine #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge from next
merge from next
- created more tests
feat: add tests, stubs and exports
feat: first pass at migrating over mdxish code
feat: add magic block support copying over legacy implementation
fix: prevent ReDos in preprocessing
chore: code cleanup
|
sorry for the re-ping here folks, a lot has changed since the initial review so wanted to double check with everyone 🙏 |
rafegoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of thoughts/questions for y'all here.
|
@eaglethrost/@maximilianfalco—looks like our magic block tests are throwing an error! 😬 Seems that images are getting wrapped in an extra |
Checking!! Weird it's passing on my local... |
|
@eaglethrost just tried and it's passing for me locally too. I thought it might be because our test runner is using Node v25/NPM v11 (instead of v22/10, which is what I had on my machine.) But even when I use that latest Node/NPM I can't replicate… Since this is a brand new test only for MDXish, and it works locally, I'm going to skip these unit tests for now. If only so we can see what a full CI run nets us. |
## Version 11.8.0 ### ✨ New & Improved * **mdxish:** add new MDXish engine ([#1243](#1243)) ([9e8f85f](9e8f85f)), closes [/github.com//pull/1243#discussion_r2587081529](https://github.com/readmeio//github.com/readmeio/markdown/pull/1243/issues/discussion_r2587081529) ### 🛠 Fixes & Updates * **stripComments:** preserve tabbed code blocks ([#1250](#1250)) ([64e58ce](64e58ce)) <!--SKIP CI-->
This PR was released!🚀 Changes included in v11.8.0 |

Warning
As of
5 Dec 2025(keeping this to track timeline) SSR formdxishhas been disabled. All contents that are rendered bymdxishwill be done client-side. For more context, refer to this thread🧰 Changes
Context
This PR exports 2 new libraries which provides a new way to render mixed Markdown + MDX content in our application.
This allows customers to flexibly embed MDX inside Markdown without relying on the strict MDX renderer or needing to migrate everything to MDX (which currently causes many errors and requires hours of cleanup)
Important
With the addition of the new libraries, we unfortunately have exceeded the maximum bundle size allowed. Specifically the current bundle size is
762KBand the limit was750KB, this has been increased to775KBChanges
mdxish.tsrenderMdxish.tsxrun.tsxbehaviour used in production, returns an RMDXModule which contains the content react component, and the table of contents🧬 QA & Testing
How to Test Locally
To test this new rendering engine directly in the ReadMe app:
npm ci&&npm run buildmake link-markdowntests/lib/mdxish/demo-docsas examples in your editorTesting In The PR App
We have prepared a PR app that has the new mdxish engine enabled by default for all projects. See it here
Things to Test in Docs
<br>)📸 Some Screenshots
These screenshots are sample MD/MDX pages that is rendered using the new libraries. All screenshots here and all demo does not have correct validation yet. We purposefuly disabled validation to demo this new engine/library.