Skip to content

Commit 2751e81

Browse files
committed
Merge pull request facebook#5784 from jimfb/getNativeNode
Add getNativeNode back, so we can get the native node when performing reorderings (instead of relyin
2 parents 0e8db6b + 4e3d38e commit 2751e81

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/renderers/shared/reconciler/ReactCompositeComponent.js

-6
Original file line numberDiff line numberDiff line change
@@ -806,13 +806,7 @@ var ReactCompositeComponentMixin = {
806806
this._processChildContext(context)
807807
);
808808
} else {
809-
// TODO: This is currently necessary due to the unfortunate caching
810-
// that ReactMount does which makes it exceedingly difficult to unmount
811-
// a set of siblings without accidentally repopulating the node cache (see
812-
// #5151). Once ReactMount no longer stores the nodes by ID, this method
813-
// can go away.
814809
var oldNativeNode = ReactReconciler.getNativeNode(prevComponentInstance);
815-
816810
ReactReconciler.unmountComponent(prevComponentInstance);
817811

818812
this._renderedNodeType = ReactNodeTypes.getType(nextRenderedElement);

0 commit comments

Comments
 (0)