Skip to content

Commit e92edad

Browse files
authored
Merge pull request #113 from Irfanwani/master
fixed some readme typos
2 parents 73173f6 + 4d39d87 commit e92edad

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Now Apple forced us to invoke CallKit ASAP when we receive voip push on iOS 13 a
2020

2121
https://developer.apple.com/documentation/pushkit/pkpushregistrydelegate/2875784-pushregistry
2222

23-
> When linking against the iOS 13 SDK or later, your implementation of this method must report notifications of type voIP to the CallKit framework by calling the reportNewIncomingCall(with:update:completion:) method
23+
> When linking against the iOS 13 SDK or later, your implementation of this method must report notifications of type VoIP to the CallKit framework by calling the `reportNewIncomingCall(with:update:completion:)` method
2424
>
2525
> On iOS 13.0 and later, if you fail to report a call to CallKit, the system will terminate your app.
2626
>
@@ -32,7 +32,7 @@ https://developer.apple.com/documentation/pushkit/pkpushregistrydelegate/2875784
3232

3333
When received VoipPush, we should present CallKit ASAP even before RN instance initialization.
3434

35-
This breaks especially if you handled almost call behavior at js side, for example:
35+
This breaks especially if you almost handled call behavior at js side, for example:
3636
Do-Not-Disturb / check if Ghost-Call / using some sip libs to register or waiting invite...etc.
3737

3838
Staff from Apple gives some advisions for these issues in the below discussion:
@@ -49,11 +49,11 @@ https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_
4949

5050
VoIP pushes were intended to specifically support incoming call notifications and nothing else.
5151

52-
If you were using voip push to do things other than `nootify incoming call`, such as: `cancel call` / `background updates`...etc, You should change to use [Notification Service Extension](https://developer.apple.com/documentation/usernotifications/unnotificationserviceextension), it contains different kind of pushs.
52+
If you were using voip push to do things other than `nootify incoming call`, such as: `cancel call` / `background updates`...etc, You should change to use [Notification Service Extension](https://developer.apple.com/documentation/usernotifications/unnotificationserviceextension), it contains different kind of pushes.
5353

5454
To use`Background Push` to [Pushing Background Updates to Your App](https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/pushing_background_updates_to_your_app),
5555
You should:
56-
1. Make sure you enabled `Xcode` -> `Signing & Capabilities` -> `Background Modes` -> `Remote Notifications` enabled
56+
1. Make sure you enabled `Xcode` -> `Signing & Capabilities` -> `Background Modes` -> `Remote Notifications`
5757
2. When sending background push from your APN back-end, the push header / payload should set:
5858
* content-available = 1
5959
* apns-push-type = 'background'
@@ -204,7 +204,7 @@ This usually
204204
#### JS API:
205205

206206
* `registerVoipToken()` --- JS method to register PushKit delegate
207-
* `onVoipNotificationCompleted(notification.uuid)` --- JS mehtod to tell PushKit we have handled received voip push
207+
* `onVoipNotificationCompleted(notification.uuid)` --- JS method to tell PushKit we have handled received voip push
208208

209209
#### Events:
210210

0 commit comments

Comments
 (0)