Skip to content

Commit 10a062f

Browse files
committed
Enable group call to support hold on iOS
1 parent cf4b2e5 commit 10a062f

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,9 +401,12 @@ class RNCallKeepExample extends React.Component {
401401
render() {
402402
}
403403
}
404-
405404
```
406405

406+
## Notes
407+
408+
- On iOS, you should call `setup` each time you want to use callKeep.
409+
407410
## Contributing
408411

409412
Any pull request, issue report and suggestion are highly welcome!

ios/RNCallKeep/RNCallKeep.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,9 @@ - (void)dealloc
126126
callUpdate.remoteHandle = [[CXHandle alloc] initWithType:_handleType value:handle];
127127
callUpdate.supportsDTMF = YES;
128128
callUpdate.supportsHolding = YES;
129-
callUpdate.supportsGrouping = NO;
130-
callUpdate.supportsUngrouping = NO;
131-
callUpdate.hasVideo = hasVideo;
129+
callUpdate.supportsGrouping = YES;
130+
callUpdate.supportsUngrouping = YES;
131+
callUpdate.hasVideo = NO;
132132
callUpdate.localizedCallerName = localizedCallerName;
133133

134134
[self.callKeepProvider reportNewIncomingCallWithUUID:uuid update:callUpdate completion:^(NSError * _Nullable error) {
@@ -245,8 +245,8 @@ - (void)requestTransaction:(CXTransaction *)transaction
245245
callUpdate.remoteHandle = startCallAction.handle;
246246
callUpdate.supportsDTMF = YES;
247247
callUpdate.supportsHolding = YES;
248-
callUpdate.supportsGrouping = NO;
249-
callUpdate.supportsUngrouping = NO;
248+
callUpdate.supportsGrouping = YES;
249+
callUpdate.supportsUngrouping = YES;
250250
callUpdate.hasVideo = NO;
251251
[self.callKeepProvider reportCallWithUUID:startCallAction.callUUID updated:callUpdate];
252252
}
@@ -452,7 +452,7 @@ - (void)provider:(CXProvider *)provider performEndCallAction:(CXEndCallAction *)
452452
-(void)provider:(CXProvider *)provider performSetHeldCallAction:(CXSetHeldCallAction *)action
453453
{
454454
#ifdef DEBUG
455-
NSLog(@"[RNCallKit][CXProviderDelegate][provider:performSetHeldCallAction]");
455+
NSLog(@"[RNCallKeep][CXProviderDelegate][provider:performSetHeldCallAction]");
456456
#endif
457457
NSString *callUUID = [self containsLowerCaseLetter:action.callUUID.UUIDString] ? action.callUUID.UUIDString : [action.callUUID.UUIDString lowercaseString];
458458

@@ -462,7 +462,7 @@ -(void)provider:(CXProvider *)provider performSetHeldCallAction:(CXSetHeldCallAc
462462

463463
- (void)provider:(CXProvider *)provider performPlayDTMFCallAction:(CXPlayDTMFCallAction *)action {
464464
#ifdef DEBUG
465-
NSLog(@"[RNCallKit][CXProviderDelegate][provider:performPlayDTMFCallAction]");
465+
NSLog(@"[RNCallKeep][CXProviderDelegate][provider:performPlayDTMFCallAction]");
466466
#endif
467467
NSString *callUUID = [self containsLowerCaseLetter:action.callUUID.UUIDString] ? action.callUUID.UUIDString : [action.callUUID.UUIDString lowercaseString];
468468
[self sendEventWithName:RNCallKeepPerformPlayDTMFCallAction body:@{ @"digits": action.digits, @"callUUID": callUUID }];

0 commit comments

Comments
 (0)