Merge pull request #49 from react-native-community/@vonovak/remove-values

Naturalclar · web-flow · commit b9dc6656d4dd · 2020-03-11T16:54:00.000+09:00
remove unneeded values array
diff --git a/ios/RNCSegmentedControl.h b/ios/RNCSegmentedControl.h
@@ -11,7 +11,6 @@
 
 @interface RNCSegmentedControl : UISegmentedControl
 
-@property (nonatomic, copy) NSArray<NSString *> *values;
 @property (nonatomic, assign) NSInteger selectedIndex;
 @property (nonatomic, copy) RCTBubblingEventBlock onChange;
 
diff --git a/ios/RNCSegmentedControl.m b/ios/RNCSegmentedControl.m
@@ -25,7 +25,6 @@ - (instancetype)initWithFrame:(CGRect)frame
 
 - (void)setValues:(NSArray<NSString *> *)values
 {
-  _values = [values copy];
   [self removeAllSegments];
   for (NSString *value in values) {
     [self insertSegmentWithTitle:value atIndex:self.numberOfSegments animated:NO];

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ - (instancetype)initWithFrame:(CGRect)frame`
`25`	`25`
`26`	`26`	`- (void)setValues:(NSArray<NSString > )values`
`27`	`27`	`{`
`28`		`- _values = [values copy];`
`29`	`28`	`[self removeAllSegments];`
`30`	`29`	`for (NSString *value in values) {`
`31`	`30`	`[self insertSegmentWithTitle:value atIndex:self.numberOfSegments animated:NO];`