Skip to content

Commit a85f0a9

Browse files
committed
chore: use community eslint config
1 parent 34a7824 commit a85f0a9

File tree

6 files changed

+144
-360
lines changed

6 files changed

+144
-360
lines changed

.circleci/config.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ aliases:
6565
yarn install --network-concurrency 1 --non-interactive --cache-folder ~/.cache/yarn & wait
6666
6767
# ANALYSE
68-
# - &eslint
69-
# name: ESLint Checks
70-
# command: yarn test:eslint
68+
- &eslint
69+
name: ESLint Checks
70+
command: yarn lint
7171

7272
- &flow
7373
name: Flow Checks
@@ -96,32 +96,32 @@ jobs:
9696
root: .
9797
paths: .
9898

99-
# eslint:
100-
# <<: *linux_defaults
101-
# steps:
102-
# - attach_workspace:
103-
# at: ~/react-native-viewpager
104-
# - run: *eslint
99+
eslint:
100+
<<: *linux_defaults
101+
steps:
102+
- attach_workspace:
103+
at: ~/react-native-segmented-control
104+
- run: *eslint
105105

106106
flow:
107107
<<: *linux_defaults
108108
steps:
109109
- attach_workspace:
110-
at: ~/react-native-viewpager
110+
at: ~/react-native-segmented-control
111111
- run: *flow
112112

113113
# jest:
114114
# <<: *linux_defaults
115115
# steps:
116116
# - attach_workspace:
117-
# at: ~/react-native-viewpager
117+
# at: ~/react-native-segmented-control
118118
# - run: *jest
119119

120120
android-compile:
121121
<<: *android_defaults
122122
steps:
123123
- attach_workspace:
124-
at: ~/react-native-viewpager
124+
at: ~/react-native-segmented-control
125125
- restore-cache: *restore-gradle-cache
126126
- run:
127127
name: Accept Android licences
@@ -152,7 +152,7 @@ jobs:
152152
<<: *macos_defaults
153153
steps:
154154
- attach_workspace:
155-
at: ~/react-native-viewpager
155+
at: ~/react-native-segmented-control
156156
- run:
157157
name: Build example app
158158
command: |-
@@ -166,9 +166,9 @@ workflows:
166166
Test:
167167
jobs:
168168
- linux-checkout
169-
# - eslint:
170-
# requires:
171-
# - linux-checkout
169+
- eslint:
170+
requires:
171+
- linux-checkout
172172
- flow:
173173
requires:
174174
- linux-checkout

.eslintrc.js

Lines changed: 3 additions & 297 deletions
Original file line numberDiff line numberDiff line change
@@ -1,298 +1,4 @@
11
module.exports = {
2-
root: true,
3-
4-
parser: "babel-eslint",
5-
6-
env: {
7-
es6: true
8-
},
9-
10-
plugins: [
11-
"eslint-comments",
12-
"flowtype",
13-
"prettier",
14-
"react",
15-
"react-hooks",
16-
"react-native",
17-
"jest"
18-
],
19-
20-
// Map from global var to bool specifying if it can be redefined
21-
globals: {
22-
__DEV__: true,
23-
__dirname: false,
24-
__fbBatchedBridgeConfig: false,
25-
alert: false,
26-
cancelAnimationFrame: false,
27-
cancelIdleCallback: false,
28-
clearImmediate: true,
29-
clearInterval: false,
30-
clearTimeout: false,
31-
console: false,
32-
document: false,
33-
escape: false,
34-
Event: false,
35-
EventTarget: false,
36-
exports: false,
37-
fetch: false,
38-
FormData: false,
39-
global: false,
40-
Map: true,
41-
module: false,
42-
navigator: false,
43-
process: false,
44-
Promise: true,
45-
requestAnimationFrame: true,
46-
requestIdleCallback: true,
47-
require: false,
48-
Set: true,
49-
setImmediate: true,
50-
setInterval: false,
51-
setTimeout: false,
52-
window: false,
53-
XMLHttpRequest: false
54-
},
55-
56-
rules: {
57-
// General
58-
"comma-dangle": [1, "always-multiline"], // allow or disallow trailing commas
59-
"no-cond-assign": 1, // disallow assignment in conditional expressions
60-
"no-console": 0, // disallow use of console (off by default in the node environment)
61-
"no-const-assign": 2, // disallow assignment to const-declared variables
62-
"no-constant-condition": 0, // disallow use of constant expressions in conditions
63-
"no-control-regex": 1, // disallow control characters in regular expressions
64-
"no-debugger": 1, // disallow use of debugger
65-
"no-dupe-class-members": 2, // Disallow duplicate name in class members
66-
"no-dupe-keys": 2, // disallow duplicate keys when creating object literals
67-
"no-empty": 0, // disallow empty statements
68-
"no-ex-assign": 1, // disallow assigning to the exception in a catch block
69-
"no-extra-boolean-cast": 1, // disallow double-negation boolean casts in a boolean context
70-
"no-extra-parens": 0, // disallow unnecessary parentheses (off by default)
71-
"no-extra-semi": 1, // disallow unnecessary semicolons
72-
"no-func-assign": 1, // disallow overwriting functions written as function declarations
73-
"no-inner-declarations": 0, // disallow function or variable declarations in nested blocks
74-
"no-invalid-regexp": 1, // disallow invalid regular expression strings in the RegExp constructor
75-
"no-negated-in-lhs": 1, // disallow negation of the left operand of an in expression
76-
"no-obj-calls": 1, // disallow the use of object properties of the global object (Math and JSON) as functions
77-
"no-regex-spaces": 1, // disallow multiple spaces in a regular expression literal
78-
"no-reserved-keys": 0, // disallow reserved words being used as object literal keys (off by default)
79-
"no-sparse-arrays": 1, // disallow sparse arrays
80-
"no-unreachable": 2, // disallow unreachable statements after a return, throw, continue, or break statement
81-
"use-isnan": 1, // disallow comparisons with the value NaN
82-
"valid-jsdoc": 0, // Ensure JSDoc comments are valid (off by default)
83-
"valid-typeof": 1, // Ensure that the results of typeof are compared against a valid string
84-
85-
// Best Practices
86-
// These are rules designed to prevent you from making mistakes. They either prescribe a better way of doing something or help you avoid footguns.
87-
88-
"block-scoped-var": 0, // treat var statements as if they were block scoped (off by default)
89-
complexity: 0, // specify the maximum cyclomatic complexity allowed in a program (off by default)
90-
"consistent-return": 0, // require return statements to either always or never specify values
91-
curly: 1, // specify curly brace conventions for all control statements
92-
"default-case": 0, // require default case in switch statements (off by default)
93-
"dot-notation": 1, // encourages use of dot notation whenever possible
94-
eqeqeq: [1, "allow-null"], // require the use of === and !==
95-
"guard-for-in": 0, // make sure for-in loops have an if statement (off by default)
96-
"no-alert": 1, // disallow the use of alert, confirm, and prompt
97-
"no-caller": 1, // disallow use of arguments.caller or arguments.callee
98-
"no-div-regex": 1, // disallow division operators explicitly at beginning of regular expression (off by default)
99-
"no-else-return": 0, // disallow else after a return in an if (off by default)
100-
"no-eq-null": 0, // disallow comparisons to null without a type-checking operator (off by default)
101-
"no-eval": 2, // disallow use of eval()
102-
"no-extend-native": 1, // disallow adding to native types
103-
"no-extra-bind": 1, // disallow unnecessary function binding
104-
"no-fallthrough": 1, // disallow fallthrough of case statements
105-
"no-floating-decimal": 1, // disallow the use of leading or trailing decimal points in numeric literals (off by default)
106-
"no-implied-eval": 1, // disallow use of eval()-like methods
107-
"no-labels": 1, // disallow use of labeled statements
108-
"no-iterator": 1, // disallow usage of __iterator__ property
109-
"no-lone-blocks": 1, // disallow unnecessary nested blocks
110-
"no-loop-func": 0, // disallow creation of functions within loops
111-
"no-multi-str": 0, // disallow use of multiline strings
112-
"no-native-reassign": 0, // disallow reassignments of native objects
113-
"no-new": 1, // disallow use of new operator when not part of the assignment or comparison
114-
"no-new-func": 2, // disallow use of new operator for Function object
115-
"no-new-wrappers": 1, // disallows creating new instances of String,Number, and Boolean
116-
"no-octal": 1, // disallow use of octal literals
117-
"no-octal-escape": 1, // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \251";
118-
"no-proto": 1, // disallow usage of __proto__ property
119-
"no-redeclare": 0, // disallow declaring the same variable more then once
120-
"no-return-assign": 1, // disallow use of assignment in return statement
121-
"no-script-url": 1, // disallow use of javascript: urls.
122-
"no-self-compare": 1, // disallow comparisons where both sides are exactly the same (off by default)
123-
"no-sequences": 1, // disallow use of comma operator
124-
"no-unused-expressions": 0, // disallow usage of expressions in statement position
125-
"no-void": 1, // disallow use of void operator (off by default)
126-
"no-warning-comments": 0, // disallow usage of configurable warning terms in comments": 1, // e.g. TODO or FIXME (off by default)
127-
"no-with": 1, // disallow use of the with statement
128-
radix: 1, // require use of the second argument for parseInt() (off by default)
129-
"semi-spacing": 1, // require a space after a semi-colon
130-
"vars-on-top": 0, // requires to declare all vars on top of their containing scope (off by default)
131-
"wrap-iife": 0, // require immediate function invocation to be wrapped in parentheses (off by default)
132-
yoda: 1, // require or disallow Yoda conditions
133-
134-
// Variables
135-
// These rules have to do with variable declarations.
136-
137-
"no-catch-shadow": 1, // disallow the catch clause parameter name being the same as a variable in the outer scope (off by default in the node environment)
138-
"no-delete-var": 1, // disallow deletion of variables
139-
"no-label-var": 1, // disallow labels that share a name with a variable
140-
"no-shadow": 1, // disallow declaration of variables already declared in the outer scope
141-
"no-shadow-restricted-names": 1, // disallow shadowing of names such as arguments
142-
"no-undef": 2, // disallow use of undeclared variables unless mentioned in a /*global */ block
143-
"no-undefined": 0, // disallow use of undefined variable (off by default)
144-
"no-undef-init": 1, // disallow use of undefined when initializing variables
145-
"no-unused-vars": [
146-
1,
147-
{ vars: "all", args: "none", ignoreRestSiblings: true }
148-
], // disallow declaration of variables that are not used in the code
149-
"no-use-before-define": 0, // disallow use of variables before they are defined
150-
151-
// Node.js
152-
// These rules are specific to JavaScript running on Node.js.
153-
154-
"handle-callback-err": 1, // enforces error handling in callbacks (off by default) (on by default in the node environment)
155-
"no-mixed-requires": 1, // disallow mixing regular variable and require declarations (off by default) (on by default in the node environment)
156-
"no-new-require": 1, // disallow use of new operator with the require function (off by default) (on by default in the node environment)
157-
"no-path-concat": 1, // disallow string concatenation with __dirname and __filename (off by default) (on by default in the node environment)
158-
"no-process-exit": 0, // disallow process.exit() (on by default in the node environment)
159-
"no-restricted-modules": 1, // restrict usage of specified node modules (off by default)
160-
"no-sync": 0, // disallow use of synchronous methods (off by default)
161-
162-
// ESLint Comments Plugin
163-
// The following rules are made available via `eslint-plugin-eslint-comments`
164-
"eslint-comments/no-aggregating-enable": 1, // disallows eslint-enable comments for multiple eslint-disable comments
165-
"eslint-comments/no-unlimited-disable": 1, // disallows eslint-disable comments without rule names
166-
"eslint-comments/no-unused-disable": 1, // disallow disables that don't cover any errors
167-
"eslint-comments/no-unused-enable": 1, // // disallow enables that don't enable anything or enable rules that weren't disabled
168-
169-
// Flow Plugin
170-
// The following rules are made available via `eslint-plugin-flowtype`
171-
"flowtype/define-flow-type": 1,
172-
"flowtype/use-flow-type": 1,
173-
174-
// Prettier Plugin
175-
// https://github.com/prettier/eslint-plugin-prettier
176-
"prettier/prettier": [2],
177-
178-
// Stylistic Issues
179-
// These rules are purely matters of style and are quite subjective.
180-
181-
"key-spacing": 0,
182-
"keyword-spacing": 1, // enforce spacing before and after keywords
183-
"jsx-quotes": [1, "prefer-double"], // enforces the usage of double quotes for all JSX attribute values which doesn’t contain a double quote
184-
"comma-spacing": 0,
185-
"no-multi-spaces": 0,
186-
"brace-style": 0, // enforce one true brace style (off by default)
187-
camelcase: 0, // require camel case names
188-
"consistent-this": 1, // enforces consistent naming when capturing the current execution context (off by default)
189-
"eol-last": 1, // enforce newline at the end of file, with no multiple empty lines
190-
"func-names": 0, // require function expressions to have a name (off by default)
191-
"func-style": 0, // enforces use of function declarations or expressions (off by default)
192-
"new-cap": 0, // require a capital letter for constructors
193-
"new-parens": 1, // disallow the omission of parentheses when invoking a constructor with no arguments
194-
"no-nested-ternary": 0, // disallow nested ternary expressions (off by default)
195-
"no-array-constructor": 1, // disallow use of the Array constructor
196-
"no-empty-character-class": 1, // disallow the use of empty character classes in regular expressions
197-
"no-lonely-if": 0, // disallow if as the only statement in an else block (off by default)
198-
"no-new-object": 1, // disallow use of the Object constructor
199-
"no-spaced-func": 1, // disallow space between function identifier and application
200-
"no-ternary": 0, // disallow the use of ternary operators (off by default)
201-
"no-trailing-spaces": 1, // disallow trailing whitespace at the end of lines
202-
"no-underscore-dangle": 0, // disallow dangling underscores in identifiers
203-
"no-mixed-spaces-and-tabs": 1, // disallow mixed spaces and tabs for indentation
204-
quotes: [1, "single", "avoid-escape"], // specify whether double or single quotes should be used
205-
"quote-props": 0, // require quotes around object literal property names (off by default)
206-
semi: 1, // require or disallow use of semicolons instead of ASI
207-
"sort-vars": 0, // sort variables within the same declaration block (off by default)
208-
"space-in-brackets": 0, // require or disallow spaces inside brackets (off by default)
209-
"space-in-parens": 0, // require or disallow spaces inside parentheses (off by default)
210-
"space-infix-ops": 1, // require spaces around operators
211-
"space-unary-ops": [1, { words: true, nonwords: false }], // require or disallow spaces before/after unary operators (words on by default, nonwords off by default)
212-
"max-nested-callbacks": 0, // specify the maximum depth callbacks can be nested (off by default)
213-
"one-var": 0, // allow just one var statement per function (off by default)
214-
"wrap-regex": 0, // require regex literals to be wrapped in parentheses (off by default)
215-
216-
// Legacy
217-
// The following rules are included for compatibility with JSHint and JSLint. While the names of the rules may not match up with the JSHint/JSLint counterpart, the functionality is the same.
218-
219-
"max-depth": 0, // specify the maximum depth that blocks can be nested (off by default)
220-
"max-len": 0, // specify the maximum length of a line in your program (off by default)
221-
"max-params": 0, // limits the number of parameters that can be used in the function declaration. (off by default)
222-
"max-statements": 0, // specify the maximum number of statement allowed in a function (off by default)
223-
"no-bitwise": 1, // disallow use of bitwise operators (off by default)
224-
"no-plusplus": 0, // disallow use of unary operators, ++ and -- (off by default)
225-
226-
// React Plugin
227-
// The following rules are made available via `eslint-plugin-react`.
228-
229-
"react/display-name": 0,
230-
"react/jsx-boolean-value": 0,
231-
"react/jsx-no-comment-textnodes": 1,
232-
"react/jsx-no-duplicate-props": 2,
233-
"react/jsx-no-undef": 2,
234-
"react/jsx-sort-props": 0,
235-
"react/jsx-uses-react": 1,
236-
"react/jsx-uses-vars": 1,
237-
"react/no-did-mount-set-state": 1,
238-
"react/no-did-update-set-state": 1,
239-
"react/no-multi-comp": 0,
240-
"react/no-string-refs": 1,
241-
"react/no-unknown-property": 0,
242-
"react/prop-types": 0,
243-
"react/react-in-jsx-scope": 1,
244-
"react/self-closing-comp": 1,
245-
"react/wrap-multilines": 0,
246-
247-
// React-Hooks Plugin
248-
// The following rules are made available via `eslint-plugin-react-hooks`
249-
"react-hooks/rules-of-hooks": "error",
250-
251-
// React-Native Plugin
252-
// The following rules are made available via `eslint-plugin-react-native`
253-
254-
"react-native/no-inline-styles": 1,
255-
256-
// Jest Plugin
257-
// The following rules are made available via `eslint-plugin-jest`.
258-
"jest/no-disabled-tests": 1,
259-
"jest/no-focused-tests": 1,
260-
"jest/no-identical-title": 1,
261-
"jest/valid-expect": 1
262-
},
263-
264-
overrides: [
265-
{
266-
files: [
267-
"**/__fixtures__/**/*.js",
268-
"**/__mocks__/**/*.js",
269-
"**/__tests__/**/*.js",
270-
"jest/**/*.js",
271-
"RNTester/**/*.js"
272-
],
273-
globals: {
274-
// Expose some Jest globals for test helpers
275-
afterAll: true,
276-
afterEach: true,
277-
beforeAll: true,
278-
beforeEach: true,
279-
expect: true,
280-
jest: true
281-
}
282-
},
283-
{
284-
files: ["**/__tests__/**/*-test.js"],
285-
env: {
286-
jasmine: true,
287-
jest: true
288-
}
289-
}
290-
],
291-
292-
settings: {
293-
react: {
294-
version: "detect"
295-
}
296-
}
297-
};
298-
2+
root: true,
3+
extends: '@react-native-community',
4+
};

.prettierrc

Lines changed: 0 additions & 8 deletions
This file was deleted.

.prettierrc.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
module.exports = {
2+
bracketSpacing: false,
3+
jsxBracketSameLine: true,
4+
singleQuote: true,
5+
trailingComma: 'all',
6+
};

0 commit comments

Comments
 (0)