Commit ab9c486
authored
fix: RN Windows Dependency and Example (#267)
* Move react-native-windows back to being a peerDependency
@rectified95 added Windows support to datetime-picker a while back. react-native-windows was added as a peer dependency, but this created warnings in cases where react-native-windows wasn't present in the host app. These warnings are currently present for all community modules with Windows support when RNW isn't installed.
A [follow-up change a few months ago](feda177) moved react-native-windows from a peerDependency to an optional dependency. This got rid of the warning but also means that:
- Every user of datetimepicker is now pulling in react-native-windows by default, even if they don't need it
- Due to how it's declared, we now have a transitive peer dependency forcing usage of RN 0.62 instead of RN 0.63
- It will potentially be broken on even react-native-windows 0.62 since we're pulling in multiple RNW versions
This change moves the dependency back to a peer dependency, loosens it to support RNW 0.63, and fixes up a couple of devDependencies that were looser than requested by react-native.
* Fix Windows Example1 parent 03ba7a2 commit ab9c486
3 files changed
+16
-24
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| 57 | + | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | 86 | | |
89 | 87 | | |
90 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8427 | 8427 | | |
8428 | 8428 | | |
8429 | 8429 | | |
8430 | | - | |
8431 | | - | |
8432 | | - | |
8433 | | - | |
| 8430 | + | |
| 8431 | + | |
| 8432 | + | |
| 8433 | + | |
8434 | 8434 | | |
8435 | 8435 | | |
8436 | 8436 | | |
8437 | 8437 | | |
8438 | | - | |
| 8438 | + | |
8439 | 8439 | | |
8440 | | - | |
8441 | | - | |
8442 | | - | |
8443 | | - | |
| 8440 | + | |
| 8441 | + | |
| 8442 | + | |
| 8443 | + | |
8444 | 8444 | | |
8445 | 8445 | | |
8446 | 8446 | | |
| |||
8963 | 8963 | | |
8964 | 8964 | | |
8965 | 8965 | | |
8966 | | - | |
| 8966 | + | |
8967 | 8967 | | |
8968 | 8968 | | |
8969 | 8969 | | |
8970 | 8970 | | |
8971 | 8971 | | |
8972 | 8972 | | |
8973 | 8973 | | |
8974 | | - | |
8975 | | - | |
8976 | | - | |
8977 | | - | |
8978 | | - | |
8979 | | - | |
8980 | | - | |
8981 | | - | |
8982 | 8974 | | |
8983 | 8975 | | |
8984 | 8976 | | |
| |||
0 commit comments