Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Metadata available for @expo-google-fonts/source-sans-pro when running expo-doctor #1469

Closed
davidlukerice opened this issue Jan 8, 2025 · 2 comments · Fixed by expo/expo#34127

Comments

@davidlukerice
Copy link

I recently started using the expo-google-fonts package and get the following message from expo-doctor on build.

> npx expo-doctor

...
✖ Validate packages against React Native Directory package metadata
...

Detailed check results:

The following issues were found when validating your dependencies against React Native Directory:
No metadata available: @expo-google-fonts/source-sans-pro

Advice: 
- Update React Native Directory to include metadata for unknown packages. Alternatively, set expo.doctor.reactNativeDirectoryCheck.listUnknownPackages in package.json to false to skip warnings about packages with no metadata, if the warning is not relevant.

I've gone ahead and suppresed the warning with the following in my package.json

  "expo": {
    "doctor": {
      "reactNativeDirectoryCheck": {
        "exclude": [
          "@expo-google-fonts/source-sans-pro"
        ]
      }
    }
  },

but I'd like to contribute the package to this repo to resolve the issue as it recommends.
I can go ahead and put in a PR according to the docs for @expo-google-fonts/source-sans-pro, but since there's so many specific expo-google-fonts packages, I was wondering if I could add the top level repo instead, and get all of the fonts at once?

@Simek
Copy link
Member

Simek commented Jan 10, 2025

Hey @davidlukerice, thanks for the report. 👍

I will add an exception for the @expo-google-fonts/* packages in the Expo CLI, so we would not cross-check their compatibility. Those packages are basically just font file files wrappers, and should work with new architecture if expo-font package is up to date.

@davidlukerice
Copy link
Author

Sounds Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants