Skip to content

Commit 4f77f87

Browse files
author
committed
chore: rename api
1 parent 54d2bf0 commit 4f77f87

File tree

2 files changed

+25
-21
lines changed

2 files changed

+25
-21
lines changed

src/Cascader.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { BuildInPlacements } from '@rc-component/trigger/lib/interface';
2-
import type { BaseSelectProps,BaseSelectPropsWithoutPrivate,BaseSelectRef } from 'rc-select';
2+
import type { BaseSelectProps, BaseSelectPropsWithoutPrivate, BaseSelectRef } from 'rc-select';
33
import { BaseSelect } from 'rc-select';
4-
import type { DisplayValueType,Placement } from 'rc-select/lib/BaseSelect';
4+
import type { DisplayValueType, Placement } from 'rc-select/lib/BaseSelect';
55
import useId from 'rc-select/lib/hooks/useId';
66
import { conductCheck } from 'rc-tree/lib/utils/conductUtil';
77
import useMergedState from 'rc-util/lib/hooks/useMergedState';
@@ -14,9 +14,9 @@ import useRefFunc from './hooks/useRefFunc';
1414
import useSearchConfig from './hooks/useSearchConfig';
1515
import useSearchOptions from './hooks/useSearchOptions';
1616
import OptionList from './OptionList';
17-
import { fillFieldNames,SHOW_CHILD,SHOW_PARENT,toPathKey,toPathKeys } from './utils/commonUtil';
18-
import { formatStrategyValues,toPathOptions } from './utils/treeUtil';
19-
import warningProps,{ warningNullOptions } from './utils/warningPropsUtil';
17+
import { fillFieldNames, SHOW_CHILD, SHOW_PARENT, toPathKey, toPathKeys } from './utils/commonUtil';
18+
import { formatStrategyValues, toPathOptions } from './utils/treeUtil';
19+
import warningProps, { warningNullOptions } from './utils/warningPropsUtil';
2020

2121
export interface ShowSearchType<OptionType extends BaseOptionType = DefaultOptionType> {
2222
filter?: (inputValue: string, options: OptionType[], fieldNames: FieldNames) => boolean;
@@ -102,8 +102,8 @@ export interface BaseCascaderProps<OptionType extends BaseOptionType = DefaultOp
102102

103103
// styles
104104
styles?: {
105-
dropdown?: React.CSSProperties;
106-
dropdownMenuColumn?: React.CSSProperties;
105+
popup?: React.CSSProperties;
106+
popupMenuColumn?: React.CSSProperties;
107107
};
108108

109109
/** @deprecated Use `placement` instead */
@@ -458,7 +458,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
458458
expandTrigger,
459459
expandIcon,
460460
loadingIcon,
461-
dropdownMenuColumnStyle: styles?.dropdownMenuColumn ?? dropdownMenuColumnStyle,
461+
dropdownMenuColumnStyle: styles?.popupMenuColumn ?? dropdownMenuColumnStyle,
462462
}),
463463
[
464464
mergedOptions,
@@ -475,7 +475,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
475475
expandIcon,
476476
loadingIcon,
477477
dropdownMenuColumnStyle,
478-
styles?.dropdownMenuColumn,
478+
styles?.popupMenuColumn,
479479
],
480480
);
481481

@@ -486,18 +486,18 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re
486486

487487
const mergedDropdownStyle: React.CSSProperties =
488488
// Search to match width
489-
styles?.dropdown ??
489+
styles?.popup ??
490490
dropdownStyle ??
491491
(mergedSearchValue && searchConfig.matchInputWidth) ??
492492
emptyOptions
493493
? // Empty keep the width
494494
{
495-
...styles?.dropdown,
495+
...styles?.popup,
496496
...dropdownStyle,
497497
}
498498
: {
499499
minWidth: 'auto',
500-
...styles?.dropdown,
500+
...styles?.popup,
501501
...dropdownStyle,
502502
};
503503

tests/index.spec.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,19 +1069,23 @@ describe('Cascader.Basic', () => {
10691069
mount(<Cascader dropdownMenuColumnStyle={{}} options={[]} />);
10701070

10711071
expect(errorSpy).toHaveBeenCalledWith(
1072-
'Warning: `dropdownMenuColumnStyle` is deprecated. Please use `styles.dropdownMenuColumn` instead.',
1072+
'Warning: `dropdownMenuColumnStyle` is deprecated. Please use `styles.popupMenuColumn` instead.',
10731073
);
10741074
errorSpy.mockReset();
10751075
});
10761076

1077-
it('`dropdownMenuColumnStyle`in Cascader options should throw a warning', () => {
1078-
const wrapper = mount(<Cascader
1079-
styles={{ dropdown: { backgroundColor: 'red' }, dropdownMenuColumn: { backgroundColor: 'blue' } }}
1077+
it('`styles` api should work correctly', () => {
1078+
const wrapper = mount(
1079+
<Cascader
1080+
styles={{
1081+
popup: { backgroundColor: 'red' },
1082+
popupMenuColumn: { backgroundColor: 'blue' },
1083+
}}
10801084
options={[]}
10811085
open
1082-
/>);
1083-
expect(wrapper.find('.rc-cascader-dropdown').props().style.backgroundColor).toEqual('red');
1084-
expect(wrapper.find('.rc-cascader-menu-item').props().style.backgroundColor).toEqual('blue');
1085-
});
1086-
1086+
/>,
1087+
);
1088+
expect(wrapper.find('.rc-cascader-dropdown').props().style.backgroundColor).toEqual('red');
1089+
expect(wrapper.find('.rc-cascader-menu-item').props().style.backgroundColor).toEqual('blue');
1090+
});
10871091
});

0 commit comments

Comments
 (0)