-
|
Hi @Can-Sahin. Can you throw some light on why the do you add process.env.PUBLIC_URL when forming router links or asset urls? Relative paths e.g. '/applications' or '/assets/images/abc.png' will work just as well even when deployed right ? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Yes, it's not needed normally but I host the example application on GitHub pages as well. Check the npm script. Otherwise the links don't work.
|
Beta Was this translation helpful? Give feedback.
-
|
I think it just confuses everyone who sees it for the first time. Please let the boilerplate serve its primary purpose: "Boilerplate". Please add a comment that it is not required. Same for the font (there are comments to remove it, thankfully), should a font choice ("Inter" or any) be part of a boilerplate? (Also consider this: bramstein/fontfaceobserver#133) |
Beta Was this translation helpful? Give feedback.
Yes, it's not needed normally but I host the example application on GitHub pages as well. Check the npm script. Otherwise the links don't work.
"publish:github": "cross-env PUBLIC_URL='/react-boilerplate-cra-template' yarn build && gh-pages -d build",