Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Commit c8e4b93

Browse files
author
Robin Luckey
committed
[CHANGE] stop passing the --no-merges flag to git. Ohloh is going to import merges now.
[NEW] is_merge_commit? method helps Ohloh decide what to do with commits
1 parent 3ff4d6b commit c8e4b93

File tree

5 files changed

+21
-1
lines changed

5 files changed

+21
-1
lines changed

lib/scm/adapters/abstract/misc.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
module Scm::Adapters
2+
class AbstractAdapter
3+
4+
def is_merge_commit?(commit)
5+
false
6+
end
7+
8+
end
9+
end

lib/scm/adapters/abstract_adapter.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,4 @@ class << self
2323
require 'lib/scm/adapters/abstract/system'
2424
require 'lib/scm/adapters/abstract/validation'
2525
require 'lib/scm/adapters/abstract/sha1'
26+
require 'lib/scm/adapters/abstract/misc'

lib/scm/adapters/git/commits.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def log(since=nil)
4949

5050

5151
def rev_list_command(since=nil)
52-
rev_list_options = "--root --reverse --no-merges --topo-order"
52+
rev_list_options = "--root --reverse --topo-order"
5353

5454
if since
5555
"cd '#{self.url}' && git rev-list #{rev_list_options} #{since}..HEAD #{self.branch_name}"

lib/scm/adapters/git/misc.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,9 @@ def create_tracking_branch(name)
6060
run "cd '#{self.url}' && git branch -f #{name} origin/#{name}"
6161
end
6262
end
63+
64+
def is_merge_commit?(commit)
65+
parent_tokens(commit).size > 1
66+
end
6367
end
6468
end

test/unit/git_misc_test.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,11 @@ def test_ls_tree
2525
end
2626
end
2727

28+
def test_is_merge_commit
29+
with_git_repository('git_walk') do |git|
30+
assert git.is_merge_commit?(Scm::Commit.new(:token => 'f264fb40c340a415b305ac1f0b8f12502aa2788f'))
31+
assert !git.is_merge_commit?(Scm::Commit.new(:token => 'd067161caae2eeedbd74976aeff5c4d8f1ccc946'))
32+
end
33+
end
2834
end
2935
end

0 commit comments

Comments
 (0)