Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot user balances #27

Open
Bill-Kunj opened this issue Aug 7, 2021 · 9 comments
Open

Snapshot user balances #27

Bill-Kunj opened this issue Aug 7, 2021 · 9 comments
Assignees
Labels
Demo All demos to outside parties PoC Anything required for PoC

Comments

@Bill-Kunj
Copy link
Collaborator

Genesis will give REV to the validator, but 'publisher', 'attestor', and 'buyer' will not have rev.
A demo requiring an initial transfer of REV to publisher, attestor, and buyer will not be as smooth as a demo in which these users already have rev.
Proposal: put the private keys for the publisher, attestor, and buyer into genesis.
Then our snapshot will already include the necessary balances

@Bill-Kunj Bill-Kunj changed the title Demo snapshot user balances Snapshot user balances Aug 7, 2021
@Bill-Kunj Bill-Kunj added Demo All demos to outside parties PoC Anything required for PoC labels Aug 7, 2021
@David405
Copy link
Collaborator

David405 commented Aug 7, 2021

Proposal: put the private keys for the publisher, attestor, and buyer into genesis.
Then our snapshot will already include the necessary balances

From what I know, this is the way it works right now.

Genesis will give REV to the validator, but 'publisher', 'attestor', and 'buyer' will not have rev.
A demo requiring an initial transfer of REV to publisher, attestor, and buyer will not be as smooth as a demo in which these users already have rev.

I am trying to understand what this means

@Bill-Kunj
Copy link
Collaborator Author

Genesis needs the private keys and initial balances. We need the keys first and then update the genesis to include them.

@Bill-Kunj
Copy link
Collaborator Author

Genesis will give REV to the validator, but 'publisher', 'attestor', and 'buyer' will not have rev.
A demo requiring an initial transfer of REV to publisher, attestor, and buyer will not be as smooth as a demo in which these users already have rev.

I am trying to understand what this means

It's an argument that the demo should not include a transfer of REV from the validator to the attestor/publisher/buyer as a part of official demos.

@David405
Copy link
Collaborator

David405 commented Aug 7, 2021

Genesis needs the private keys and initial balances. We need the keys first and then update the genesis to include them.

As I said, the keys are already inside genesis.

@David405
Copy link
Collaborator

David405 commented Aug 7, 2021

So, as I said earlier, I suggest we use the same rnode snapshot so we can all can all work with the same registry URI, what do you think?

@Bill-Kunj
Copy link
Collaborator Author

Bill-Kunj commented Aug 7, 2021

So, as I said earlier, I suggest we use the same rnode snapshot so we can all can all work with the same registry URI, what do you think?

This is a great idea. Remember that the snapshot needs to be available to everyone, including the demo systems.
Where shall we keep it?

Also, as I update and test the rholang, the URI will change. Which means we'll need to update the snapshot from time-to-time.

@David405 David405 closed this as completed Aug 7, 2021
@David405 David405 reopened this Aug 7, 2021
@David405
Copy link
Collaborator

David405 commented Aug 7, 2021

sorry about the closing, it was a mistake

@Bill-Kunj
Copy link
Collaborator Author

I think https://docs.github.com/en/github/managing-large-files/versioning-large-files will work for snapshot storage.

@Bill-Kunj
Copy link
Collaborator Author

@TheoXD @David405 This remains a technical issue we need to figure out. Once we release, upgrades are inevitable and the URI will be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Demo All demos to outside parties PoC Anything required for PoC
Projects
None yet
Development

No branches or pull requests

4 participants