Merge pull request #196 from gregolsky/v4.0

RDBC-265

Author: gregolsky

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ravendb",
-  "version": "4.0.8",
+  "version": "4.0.9",
   "description": "RavenDB client for Node.js",
   "files": [
     "dist/"

src/Documents/Commands/SeedIdentityForCommand.ts

@@ -3,6 +3,7 @@ import { throwError } from "../../Exceptions";
 import { HttpRequestParameters } from "../../Primitives/Http";
 import { ServerNode } from "../../Http/ServerNode";
 import * as stream from "readable-stream";
+import { TypeUtil } from "../../Utility/TypeUtil";
 
 export class SeedIdentityForCommand extends RavenCommand<number> {
 
@@ -34,6 +35,7 @@ export class SeedIdentityForCommand extends RavenCommand<number> {
         if (this._forced) {
             uri += "&force=true";
         }
+
         return {
             method: "POST",
             uri
@@ -49,7 +51,7 @@ export class SeedIdentityForCommand extends RavenCommand<number> {
         await this._defaultPipeline(_ => body = _).process(bodyStream)
             .then(result => {
                 const newSeedValue = result["newSeedValue"];
-                if (!newSeedValue) {
+                if (TypeUtil.isNullOrUndefined(newSeedValue)) {
                     this._throwInvalidResponse();
                 }
 

test/Issues/RDBC_265.ts

@@ -0,0 +1,58 @@
+import * as mocha from "mocha";
+import * as assert from "assert";
+import { User, Company, Order } from "../Assets/Entities";
+import { testContext, disposeTestDocumentStore } from "../Utils/TestUtil";
+
+import {
+    RavenErrorType,
+    IDocumentStore,
+    SeedIdentityForCommand,
+    GetIdentitiesOperation,
+} from "../../src";
+
+describe("RDBC-265", function () {
+
+    let store: IDocumentStore;
+
+    beforeEach(async function () {
+        store = await testContext.getDocumentStore();
+    });
+
+    afterEach(async () => 
+        await disposeTestDocumentStore(store));
+
+    it("sets identity back to 0 only when forced", async () => {
+        {
+            const session = store.openSession();
+            const user = Object.assign(new User(), { lastName: "Adi" });
+            await session.store(user, "users|");
+            await session.saveChanges();
+            assert.strictEqual(user.id, "users/1");
+        }
+
+        let identities = await store.maintenance.send(new GetIdentitiesOperation());
+        assert.strictEqual(identities["users|"], 1);
+
+        let command = new SeedIdentityForCommand("users", 0);
+        await store.getRequestExecutor().execute(command);
+
+        identities = await store.maintenance.send(new GetIdentitiesOperation());
+        assert.strictEqual(identities["users|"], 1);
+
+        command = new SeedIdentityForCommand("users", 0, true);
+        await store.getRequestExecutor().execute(command);
+
+        identities = await store.maintenance.send(new GetIdentitiesOperation());
+        assert.strictEqual(identities["users|"], 0);
+
+        // the below won't work however
+        // due to https://github.com/ravendb/ravendb/blob/v4.1/test/SlowTests/Issues/RavenDB_9576.cs#L14
+        // {
+        //     const session = store.openSession();
+        //     const user = Object.assign(new User(), { lastName: "Avivi" });
+        //     await session.store(user, "users|");
+        //     await session.saveChanges();
+        //     assert.strictEqual(user.id, "users/1");
+        // }
+    });
+});

test/Ported/NextAndSeedIdentitiesTest.ts

@@ -103,5 +103,4 @@ describe("NextAndSeedIdentitiesTest", function () {
         const identities = await store.maintenance.send(new GetIdentitiesOperation());
         assert.strictEqual(identities["users|"], 1991);
     });
-
 });