Skip to content

Commit 75d1fae

Browse files
j-schambacherpopcornmix
authored andcommitted
overlays: Sets i2s_clk_producer as default for Hifiberry DACplusADC
As we have never released a (standard) DACplusADC board with onboard clocks, we can simply use a fixed setup avoiding incompatibilities with Pi5 during driver init. Setting 'hifiberry-dacplusadc,slave' in the overlays disables the failing clock probing mechanism. Removes 'slave' parameter description from README which is still supported but not needed. Signed-off-by: j-schambacher <[email protected]>
1 parent 4c76877 commit 75d1fae

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

arch/arm/boot/dts/overlays/README

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1791,7 +1791,7 @@ Params: <None>
17911791

17921792

17931793
Name: hifiberry-dac8x
1794-
Info: Configures the HifiBerry DAC8X audio cards (only on PI5)
1794+
Info: Configures the HifiBerry DAC8X audio cards (only on Pi5)
17951795
Load: dtoverlay=hifiberry-dac8x
17961796
Params: <None>
17971797

@@ -1878,8 +1878,6 @@ Params: 24db_digital_gain Allow gain to be applied via the PCM512x codec
18781878
responsibility of the user to ensure that
18791879
the Digital volume control is set to a value
18801880
that does not result in clipping/distortion!)
1881-
slave Force DAC+ADC into slave mode, using Pi as
1882-
master for bit clock and frame clock.
18831881
leds_off If set to 'true' the onboard indicator LEDs
18841882
are switched off at all times.
18851883

arch/arm/boot/dts/overlays/hifiberry-dacplusadc-overlay.dts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Definitions for HiFiBerry DAC+ADC
1+
// Definitions for HiFiBerry DAC+ADC, no onboard clocks
22
/dts-v1/;
33
/plugin/;
44

@@ -15,8 +15,8 @@
1515
};
1616
};
1717

18-
frag1: fragment@1 {
19-
target = <&i2s_clk_consumer>;
18+
fragment@1 {
19+
target = <&i2s_clk_producer>;
2020
__overlay__ {
2121
status = "okay";
2222
};
@@ -58,17 +58,15 @@
5858
target = <&sound>;
5959
hifiberry_dacplusadc: __overlay__ {
6060
compatible = "hifiberry,hifiberry-dacplusadc";
61-
i2s-controller = <&i2s_clk_consumer>;
61+
i2s-controller = <&i2s_clk_producer>;
62+
hifiberry-dacplusadc,slave;
6263
status = "okay";
6364
};
6465
};
6566

6667
__overrides__ {
6768
24db_digital_gain =
6869
<&hifiberry_dacplusadc>,"hifiberry,24db_digital_gain?";
69-
slave = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,slave?",
70-
<&frag1>,"target:0=",<&i2s_clk_producer>,
71-
<&hifiberry_dacplusadc>,"i2s-controller:0=",<&i2s_clk_producer>;
7270
leds_off = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,leds_off?";
7371
};
7472
};

0 commit comments

Comments
 (0)