ci: update Swiftlint rules

Author: imaginaris

.swiftlint.yml

@@ -2,18 +2,14 @@ included:
   - Sources
   - Tests
 
-disabled_rules:
-- identifier_name
-- nesting
-
 opt_in_rules:
 - empty_count
 - empty_string
 
-excluded:
-- Carthage
-- Pods
-- SwiftLint/Common/3rdPartyLib
+disabled_rules:
+- nesting
+- todo
+- identifier_name
 
 line_length:
     warning: 150
@@ -40,11 +36,12 @@ file_length:
     ignore_comment_only_lines: true
 
 cyclomatic_complexity:
-    warning: 15
+    warning: 25
     error: 25
 
 large_tuple:
-    warning: 4
-    error: 4
+    warning: 3
+    error: 3
 
 reporter: "xcode"
+

Podfile

@@ -8,7 +8,7 @@ use_frameworks!
 target 'Tests' do
   pod 'Quick', '~> 5.0'
   pod 'Nimble'
-  pod 'SwiftLint', '~> 0.48.0' # Version 0.49+ requires macOS 12 and Swift 5.6
+  pod 'SwiftLint', '~> 0.50'
   pod 'RSDKUtils', :path => './RSDKUtils.podspec'
   pod 'RSDKUtils/TestHelpers', :path => './RSDKUtils.podspec'
   pod 'RSDKUtils/Nimble', :path => './RSDKUtils.podspec'

Podfile.lock

@@ -11,7 +11,7 @@ PODS:
   - RSDKUtils/RLogger (4.0.0)
   - RSDKUtils/TestHelpers (4.0.0):
     - RSDKUtils/Main
-  - SwiftLint (0.48.0)
+  - SwiftLint (0.51.0)
 
 DEPENDENCIES:
   - Nimble
@@ -20,7 +20,7 @@ DEPENDENCIES:
   - RSDKUtils/Nimble (from `./RSDKUtils.podspec`)
   - RSDKUtils/RLogger (from `./RSDKUtils.podspec`)
   - RSDKUtils/TestHelpers (from `./RSDKUtils.podspec`)
-  - SwiftLint (~> 0.48.0)
+  - SwiftLint (~> 0.50)
 
 SPEC REPOS:
   trunk:
@@ -36,8 +36,8 @@ SPEC CHECKSUMS:
   Nimble: 5316ef81a170ce87baf72dd961f22f89a602ff84
   Quick: 749aa754fd1e7d984f2000fe051e18a3a9809179
   RSDKUtils: e2a63eb729298706abe02e735436a2586c65e164
-  SwiftLint: 284cea64b6187c5d6bd83e9a548a64104d546447
+  SwiftLint: 1b7561918a19e23bfed960e40759086e70f4dba5
 
-PODFILE CHECKSUM: 01c054113b493e5c0ad989d688e456e75430caaa
+PODFILE CHECKSUM: f6ba2f14867e1900fb90942ba329b080648b55b0
 
-COCOAPODS: 1.11.3
+COCOAPODS: 1.12.1

RSDKUtils.xcodeproj/project.pbxproj

@@ -291,7 +291,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "\"${PODS_ROOT}/SwiftLint/swiftlint\" lint --config \"${SRCROOT}/.swiftlint.yml\" --strict\n";
+			shellScript = "\"${PODS_ROOT}/SwiftLint/swiftlint\" lint --strict\n";
 		};
 /* End PBXShellScriptBuildPhase section */
 

Sources/RSDKUtilsMain/Extensions/UIColor+Extensions.swift

@@ -50,8 +50,10 @@ public extension UIColor {
     /// - Parameter anotherColor: A color to compare with.
     /// - Returns: `true` if both colors have the same RGBA values.
     func isRGBAEqual(to anotherColor: UIColor) -> Bool {
-        var rgba1: (r: CGFloat, g: CGFloat, b: CGFloat, a: CGFloat) = (0, 0, 0, 0)
-        var rgba2: (r: CGFloat, g: CGFloat, b: CGFloat, a: CGFloat) = (0, 0, 0, 0)
+        // swiftlint:disable:next large_tuple
+        typealias RGBA = (r: CGFloat, g: CGFloat, b: CGFloat, a: CGFloat)
+        var rgba1 = RGBA(0, 0, 0, 0)
+        var rgba2 = RGBA(0, 0, 0, 0)
 
         getRed(&rgba1.r, green: &rgba1.g, blue: &rgba1.b, alpha: &rgba1.a)
         anotherColor.getRed(&rgba2.r, green: &rgba2.g, blue: &rgba2.b, alpha: &rgba2.a)

Tests/.swiftlint.yml

@@ -0,0 +1,2 @@
+disabled_rules:
+- force_cast

Tests/Tests/NSObjectExtensionsSpec.swift

@@ -67,7 +67,6 @@ class NSObjectExtensionsSpec: QuickSpec {
                 #if os(iOS)
                 it("will return true for private apple class instance") {
                     let window = UIWindow()
-                    // swiftlint:disable:next force_cast
                     let object = window.value(forKey: "_systemGestureGateForGestures") as! NSObject // _UISystemGestureGateGestureRecognizer
                     expect(object.isApplePrivateClass()).to(beTrue())
                 }