chore: fix sonar cloud issues

Author: SoumenRautray

Sources/REventLogger/EventLoggerModule.swift

@@ -87,8 +87,8 @@ final class REventLoggerModule {
     }
 
     func sendAllEventsInStorage(deleteOldEventsOnFailure: Bool = false) {
-        let eventsStorage = self.eventsStorage.getAllEvents()
-        let storedEvents = (ids: Array(eventsStorage.keys), events: Array(eventsStorage.values))
+        let events = self.eventsStorage.getAllEvents()
+        let storedEvents = (ids: Array(events.keys), events: Array(events.values))
         eventsSender.sendEvents(events: storedEvents.events) { result in
             switch result {
             case .success:
@@ -123,9 +123,8 @@ final class REventLoggerModule {
     private func checkEventsExpirationAndStorage() {
         loggerQueue.async { [weak self] in
             guard let self else { return }
-            if self.isTtlExpired() == true || self.eventsStorage.getEventCount() >= REventConstants.maxEventCount {
+            if self.isTtlExpired() || self.eventsStorage.getEventCount() >= REventConstants.maxEventCount {
                 self.sendAllEventsInStorage()
-                return
             }
         }
     }

Sources/REventLogger/Networking/NetworkManager.swift

@@ -13,7 +13,8 @@ class NetworkManager {
 
         dataTask = defaultSession.createURLSessionDataTask(with: request) { data, response, error in
 
-            if let error = error { completion(nil, error)
+            if let error = error {
+                completion(nil, error)
                 return
             }
             if let response = response as? HTTPURLResponse, 200...201 ~= response.statusCode {

Sources/REventLogger/REventLogger.swift

@@ -20,7 +20,9 @@ public final class REventLogger {
     var configuration: EventLoggerConfiguration?
     private var isConfigured = false
 
-    private init() { }
+    private init() {
+        // This initializer is private to prevent instantiation.
+    }
 
     /// Function to configure the Event Logger
     /// - Parameters:
@@ -46,7 +48,6 @@ public final class REventLogger {
         isConfigured = true
         onCompletion?(true, "EventLogger is configured")
 
-        // TODO: Implement App Life cycle
         if eventLogger?.isTtlExpired() == true {
             eventLogger?.sendAllEventsInStorage()
         }
@@ -89,10 +90,10 @@ public final class REventLogger {
     }
 
     private func resolveDependency() -> TypedDependencyManager {
-        let dependencyManager = TypedDependencyManager()
-        let mainContainer = MainContainerFactory.create(dependencyManager: dependencyManager)
-        dependencyManager.appendContainer(mainContainer)
-        return dependencyManager
+        let manager = TypedDependencyManager()
+        let mainContainer = MainContainerFactory.create(dependencyManager: manager)
+        manager.appendContainer(mainContainer)
+        return manager
     }
 
     private func configureModules(dependencyManager: TypedDependencyManager) {