Skip to content

Commit 1fc4252

Browse files
committed
point container registry to rake-compiler/rake-compiler-dock-image
with new tag format
1 parent 936f21f commit 1fc4252

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

History.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,17 @@
99
* Ensure autoconf is installed in the base iamges.
1010
* Start publishing snapshots to ghcr.io
1111
* Bump JRuby to 9.4.0.0
12+
* Move docker images to ghcr.io/rake-compiler:
13+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-jruby`
14+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-aarch64-linux`
15+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-arm-linux`
16+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-arm64-darwin`
17+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x64-mingw-ucrt`
18+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x64-mingw32`
19+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x86-linux`
20+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x86-mingw32`
21+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x86_64-darwin`
22+
* `ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x86_64-linux`
1223

1324

1425
1.2.2 / 2022-06-27

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ jobs:
187187
name: "native-gem"
188188
runs-on: ubuntu-latest
189189
container:
190-
image: "larskanis/rake-compiler-dock-mri-x86_64-linux:1.2.1"
190+
image: "ghcr.io/rake-compiler/rake-compiler-dock-image:1.2.2-mri-x86_64-linux"
191191
steps:
192192
- uses: actions/checkout@v2
193193
- run: bundle install && bundle exec rake gem:x86_64-linux:rcd
@@ -242,7 +242,7 @@ The following variables are recognized by rake-compiler-dock:
242242
Must be a space separated list out of `x86-mingw32`, `x64-mingw-ucrt`, `x64-mingw32`, `x86-linux`, `x86_64-linux`, `arm-linux`, `aarch64-linux`, `x86_64-darwin` and `arm64-darwin`.
243243
It is ignored when `rubyvm` is set to `:jruby`.
244244
* `RCD_IMAGE` - The docker image that is downloaded and started.
245-
Defaults to "larskanis/rake-compiler-dock:IMAGE_VERSION" with an image version that is determined by the gem version.
245+
Defaults to "ghcr.io/rake-compiler/rake-compiler-dock-image:IMAGE_VERSION-PLATFORM" with an image version that is determined by the gem version.
246246

247247
The following variables are passed through to the docker container without modification:
248248

lib/rake_compiler_dock/starter.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,11 @@ def container_image_name(options={})
164164
image_name = ENV['RCD_IMAGE'] || ENV['RAKE_COMPILER_DOCK_IMAGE']
165165
return image_name unless image_name.nil?
166166

167-
"%s/rake-compiler-dock-%s%s:%s" % [
167+
"%s/rake-compiler-dock-image:%s-%s%s" % [
168168
container_registry,
169+
IMAGE_VERSION,
169170
container_rubyvm(options),
170171
container_jrubyvm?(options) ? "" : "-#{options.fetch(:platform)}",
171-
IMAGE_VERSION,
172172
]
173173
end
174174
end

test/test_starter.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,20 +49,20 @@ def test_container_image_name
4949

5050
# mri platform arg
5151
assert_equal(
52-
"ghcr.io/rake-compiler/rake-compiler-dock-mri-platform-option-value:#{IMAGE_VERSION}",
52+
"ghcr.io/rake-compiler/rake-compiler-dock-image:#{IMAGE_VERSION}-mri-platform-option-value",
5353
Starter.container_image_name({:platform => "platform-option-value"}),
5454
)
5555

5656
# jruby rubyvm arg
5757
assert_equal(
58-
"ghcr.io/rake-compiler/rake-compiler-dock-jruby:#{IMAGE_VERSION}",
58+
"ghcr.io/rake-compiler/rake-compiler-dock-image:#{IMAGE_VERSION}-jruby",
5959
Starter.container_image_name({:rubyvm => "jruby"}),
6060
)
6161

6262
# container registry env var
6363
with_env({"CONTAINER_REGISTRY" => "registry-value"}) do
6464
assert_equal(
65-
"registry-value/rake-compiler-dock-mri-x86_64-darwin:#{IMAGE_VERSION}",
65+
"registry-value/rake-compiler-dock-image:#{IMAGE_VERSION}-mri-x86_64-darwin",
6666
Starter.container_image_name({:platform => "x86_64-darwin"}),
6767
)
6868
end

0 commit comments

Comments
 (0)