Only set writeToDisk for the webpack-dev-server (#2743)

justin808 · web-flow · commit ae4609529427 · 2020-10-13T11:50:48.000+01:00
Otherwise the manifest.json is written twice for every compilation. See webdeveric/webpack-assets-manifest#89 for more details.
diff --git a/package/environments/base.js b/package/environments/base.js
@@ -44,7 +44,7 @@ const getPluginList = () => {
     'Manifest',
     new WebpackAssetsManifest({
       entrypoints: true,
-      writeToDisk: true,
+      writeToDisk: !!process.env.WEBPACK_DEV_SERVER,
       publicPath: config.publicPathWithoutCDN
     })
   )

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ const getPluginList = () => {`
`44`	`44`	`'Manifest',`
`45`	`45`	`new WebpackAssetsManifest({`
`46`	`46`	`entrypoints: true,`
`47`		`- writeToDisk: true,`
	`47`	`+ writeToDisk: !!process.env.WEBPACK_DEV_SERVER,`
`48`	`48`	`publicPath: config.publicPathWithoutCDN`
`49`	`49`	`})`
`50`	`50`	`)`