Fix abstraction for RecurringSchedule and Process

Author: cupatea

lib/solid_queue/processes/registrable.rb

@@ -58,5 +58,9 @@ def heartbeat
         self.process = nil
         wake_up
       end
+
+      def refresh_registered_process
+        process.update_columns(metadata: metadata.compact)
+      end
   end
 end

lib/solid_queue/scheduler.rb

@@ -30,11 +30,8 @@ def run
         loop do
           break if shutting_down?
 
-          recurring_schedule.update_scheduled_tasks.tap do |updated_tasks|
-            if updated_tasks.any?
-              process.update_columns(metadata: metadata.compact)
-            end
-          end
+          recurring_schedule.reload!
+          refresh_registered_process if recurring_schedule.changed?
 
           interruptible_sleep(polling_interval)
         end

lib/solid_queue/scheduler/recurring_schedule.rb

@@ -4,12 +4,13 @@ module SolidQueue
   class Scheduler::RecurringSchedule
     include AppExecutor
 
-    attr_reader :static_tasks, :configured_tasks, :scheduled_tasks
+    attr_reader :static_tasks, :configured_tasks, :scheduled_tasks, :changes
 
     def initialize(tasks)
       @static_tasks = Array(tasks).map { |task| SolidQueue::RecurringTask.wrap(task) }.select(&:valid?)
       @configured_tasks = @static_tasks + dynamic_tasks
       @scheduled_tasks = Concurrent::Hash.new
+      @changes = Concurrent::Hash.new
     end
 
     def empty?
@@ -44,10 +45,6 @@ def unschedule_old_dynamic_tasks
       end
     end
 
-    def update_scheduled_tasks
-      schedule_new_dynamic_tasks + unschedule_old_dynamic_tasks
-    end
-
     def schedule_task(task)
       scheduled_tasks[task.key] = schedule(task)
     end
@@ -65,6 +62,21 @@ def task_keys
       static_task_keys + dynamic_tasks.map(&:key)
     end
 
+    def reload!
+      { added_tasks: schedule_new_dynamic_tasks,
+        removed_tasks: unschedule_old_dynamic_tasks }.each do |key, values|
+        if values.any?
+          changes[key] = values
+        else
+          changes.delete(key)
+        end
+      end
+    end
+
+    def changed?
+      @changes.any?
+    end
+
     private
       def persist_static_tasks
         SolidQueue::RecurringTask.static.where.not(key: static_task_keys).delete_all