Skip to content

Commit 0fc7b70

Browse files
committed
Add test:arel to test separately from adapters
Previously, all of the Arel tests would be run with every database adapter. This is not necessarily a problem, but these tests end up running redundantly for each adapter/database combination even though they do not interact with adapters at all. This commit follows up a commit in Rails [1] that added a new test:arel task for Active Record. This additional step creates a place for Arel to be tested a single time, so that a followup PR to Rails can filter out Arel tests when testing adapters. Since the task is only present on the main branch, it cannot run for all Rails versions and must be a special case. [1] rails/rails@f362f07
1 parent b3bc915 commit 0fc7b70

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pipeline-generate

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,10 @@ end
299299
if REPO_ROOT.join("actionview/Rakefile").read.include?("task :ujs")
300300
step_for("actionview", "test:ujs", service: "actionview")
301301
end
302+
if REPO_ROOT.join("activerecord/Rakefile").read.include?("Rake::TestTask.new(:arel)")
303+
# Added during 7.1 development on main
304+
step_for("activerecord", "test:arel", service: "default")
305+
end
302306
steps_for("activejob", "test:integration", service: "activejob") do |x|
303307
# Enable soft_fail until the problem in queue_classic is solved.
304308
# https://github.com/rails/rails/pull/37517#issuecomment-545370408

0 commit comments

Comments
 (0)