Skip to content

Commit 1d5a5ee

Browse files
committed
Merge branch 'update_supported_rails_rubies' into fix-integration-2
2 parents 2c2c996 + 73ed1e9 commit 1d5a5ee

File tree

5 files changed

+41
-4
lines changed

5 files changed

+41
-4
lines changed

.github/workflows/ci.yml

+13-1
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,23 @@ jobs:
88
fail-fast: false
99
matrix:
1010
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
11-
rails: ['7.0', '7.1', 'edge']
11+
rails: ['7.0', '7.1', '7.2', '8.0', 'edge']
1212
exclude:
13+
- ruby: '2.7'
14+
rails: '7.2'
15+
- ruby: '2.7'
16+
rails: '8.0'
1317
- ruby: '2.7'
1418
rails: 'edge'
1519
- ruby: '3.0'
20+
rails: '7.2'
21+
- ruby: '3.0'
22+
rails: '8.0'
23+
- ruby: '3.0'
24+
rails: 'edge'
25+
- ruby: '3.1'
26+
rails: '8.0'
27+
- ruby: '3.1'
1628
rails: 'edge'
1729
env:
1830
BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails }}.gemfile

gemfiles/rails_7.2.gemfile

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
source "https://rubygems.org"
2+
3+
gem "actionpack", github: "rails/rails", branch: "7-2-stable"
4+
gem "activerecord", github: "rails/rails", branch: "7-2-stable"
5+
gem "railties", github: "rails/rails", branch: "7-2-stable"
6+
7+
gem "rack", ">= 2.2.4", "< 4"
8+
gem "sqlite3"
9+
10+
gemspec :path => "../"
11+

gemfiles/rails_8.0.gemfile

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
source "https://rubygems.org"
2+
3+
gem "actionpack", github: "rails/rails", branch: "8-0-stable"
4+
gem "activerecord", github: "rails/rails", branch: "8-0-stable"
5+
gem "railties", github: "rails/rails", branch: "8-0-stable"
6+
7+
gem "rack", ">= 2.2.4", "< 4"
8+
gem "sqlite3"
9+
10+
gemspec :path => "../"
11+

test/helper.rb

+3-2
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ class ActionDispatch::IntegrationTest < ActiveSupport::TestCase
4646

4747
def self.build_app(routes, options)
4848
RoutedRackApp.new(routes || ActionDispatch::Routing::RouteSet.new) do |middleware|
49-
middleware.use ActionDispatch::Session::ActiveRecordStore, options.reverse_merge(:key => '_session_id')
5049
middleware.use ActionDispatch::DebugExceptions
5150
middleware.use ActionDispatch::ActionableExceptions
5251
middleware.use ActionDispatch::Callbacks
5352
middleware.use ActionDispatch::Cookies
5453
middleware.use ActionDispatch::Flash
5554
middleware.use Rack::MethodOverride
5655
middleware.use Rack::Head
56+
middleware.use ActionDispatch::Session::ActiveRecordStore, options.reverse_merge(key: "_session_id")
5757
yield(middleware) if block_given?
5858
end
5959
end
@@ -71,7 +71,8 @@ def with_test_route_set(options = {})
7171
actions.each { |action| get action, controller: "#{controller_namespace}/test" }
7272
end
7373

74-
@app = self.class.build_app(set, options)
74+
self.class.app = self.class.build_app(set, options)
75+
7576
yield
7677
end
7778
end

test/logger_silencer_test.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ def setup
3939
def test_log_silencer_with_logger_not_raise_exception
4040
with_logger ActiveSupport::Logger.new(Tempfile.new("tempfile")) do
4141
with_test_route_set do
42-
get "/set_session_value"
42+
assert_nothing_raised do
43+
get "/set_session_value"
44+
end
4345
end
4446
end
4547
end

0 commit comments

Comments
 (0)