Fix rubocop offenses

Author: mshibuya

.rubocop.yml

@@ -5,6 +5,9 @@ AllCops:
     - 'spec/dummy_app/db/schema.rb'
     - 'vendor/bundle/**/*'
 
+Metrics/AbcSize:
+  Max: 69.98 # TODO: Lower to 15
+
 Metrics/BlockNesting:
   Max: 3
 

app/helpers/rails_admin/application_helper.rb

@@ -19,8 +19,8 @@ def authorized?(action, abstract_model = nil, object = nil)
 
     def current_action?(action, abstract_model = @abstract_model, object = @object)
       @action.custom_key == action.custom_key &&
-      abstract_model.try(:to_param) == @abstract_model.try(:to_param) &&
-      (@object.try(:persisted?) ? @object.id == object.try(:id) : !object.try(:persisted?))
+        abstract_model.try(:to_param) == @abstract_model.try(:to_param) &&
+        (@object.try(:persisted?) ? @object.id == object.try(:id) : !object.try(:persisted?))
     end
 
     def action(key, abstract_model = nil, object = nil)
@@ -116,7 +116,7 @@ def breadcrumb(action = @action, _acc = [])
           o = a.send(:eval, 'bindings[:object]')
           content_tag(:li, class: current_action?(a, am, o) && 'active') do
             crumb = begin
-              if not current_action?(a, am, o)
+              if !current_action?(a, am, o)
                 if a.http_methods.include?(:get)
                   link_to url_for(action: a.action_name, controller: 'rails_admin/main', model_name: am.try(:to_param), id: (o.try(:persisted?) && o.try(:id) || nil)), class: 'pjax' do
                     wording_for(:breadcrumb, a, am, o)
@@ -155,13 +155,13 @@ def bulk_menu(abstract_model = @abstract_model)
       return '' if actions.empty?
       content_tag :li, class: 'dropdown', style: 'float:right' do
         content_tag(:a, class: 'dropdown-toggle', :'data-toggle' => 'dropdown', href: '#') { t('admin.misc.bulk_menu_title').html_safe + '<b class="caret"></b>'.html_safe } +
-        content_tag(:ul, class: 'dropdown-menu', style: 'left:auto; right:0;') do
-          actions.collect do |action|
-            content_tag :li do
-              link_to wording_for(:bulk_link, action), '#', onclick: "jQuery('#bulk_action').val('#{action.action_name}'); jQuery('#bulk_form').submit(); return false;"
-            end
-          end.join.html_safe
-        end
+          content_tag(:ul, class: 'dropdown-menu', style: 'left:auto; right:0;') do
+            actions.collect do |action|
+              content_tag :li do
+                link_to wording_for(:bulk_link, action), '#', onclick: "jQuery('#bulk_action').val('#{action.action_name}'); jQuery('#bulk_form').submit(); return false;"
+              end
+            end.join.html_safe
+          end
       end.html_safe
     end
   end

app/helpers/rails_admin/form_builder.rb

@@ -12,10 +12,10 @@ def generate(options = {})
         )
 
         object_infos +
-        visible_groups(options[:model_config], generator_action(options[:action], options[:nested_in])).collect do |fieldset|
-          fieldset_for fieldset, options[:nested_in]
-        end.join.html_safe +
-        (options[:nested_in] ? '' : @template.render(partial: 'rails_admin/main/submit_buttons'))
+          visible_groups(options[:model_config], generator_action(options[:action], options[:nested_in])).collect do |fieldset|
+            fieldset_for fieldset, options[:nested_in]
+          end.join.html_safe +
+          (options[:nested_in] ? '' : @template.render(partial: 'rails_admin/main/submit_buttons'))
       end
     end
 
@@ -36,7 +36,7 @@ def field_wrapper_for(field, nested_in)
         unless nested_field_association?(field, nested_in)
           @template.content_tag(:div, class: "form-group control-group #{field.type_css_class} #{field.css_class} #{'error' if field.errors.present?}", id: "#{dom_id(field)}_field") do
             label(field.method_name, capitalize_first_letter(field.label), class: 'col-sm-2 control-label') +
-            (field.nested_form ? field_for(field) : input_for(field))
+              (field.nested_form ? field_for(field) : input_for(field))
           end
         end
       else
@@ -49,8 +49,8 @@ def input_for(field)
       css += ' has-error' if field.errors.present?
       @template.content_tag(:div, class: css) do
         field_for(field) +
-        errors_for(field) +
-        help_for(field)
+          errors_for(field) +
+          help_for(field)
       end
     end
 

lib/rails_admin/adapters/active_record.rb

@@ -56,8 +56,8 @@ def associations
       def properties
         columns = model.columns.reject do |c|
           c.type.blank? ||
-            DISABLED_COLUMN_TYPES.include?(c.type.to_sym) ||
-            c.try(:array)
+          DISABLED_COLUMN_TYPES.include?(c.type.to_sym) ||
+          c.try(:array)
         end
         columns.collect do |property|
           Property.new(property, model)

lib/rails_admin/adapters/mongoid/property.rb

@@ -71,7 +71,7 @@ def read_only?
 
         def object_field_type
           if [:belongs_to, :referenced_in, :embedded_in].
-            include?(model.relations.values.detect { |r| r.foreign_key.try(:to_sym) == name }.try(:macro).try(:to_sym))
+             include?(model.relations.values.detect { |r| r.foreign_key.try(:to_sym) == name }.try(:macro).try(:to_sym))
             :bson_object_id
           else
             :string

lib/rails_admin/config/configurable.rb

@@ -29,7 +29,7 @@ module ClassMethods
         # accessed by an instance method. Both go by the name of the option.
         def register_instance_option(option_name, scope = self, &default)
           options = scope.instance_variable_get('@config_options') ||
-                      scope.instance_variable_set('@config_options', {})
+                    scope.instance_variable_set('@config_options', {})
 
           option_name = option_name.to_s
           options[option_name] = nil

lib/rails_admin/config/fields/factories/enum.rb

@@ -8,8 +8,8 @@
 
   # NOTICE: _method_name could be `to_enum` and this method defined in Object.
   if !Object.respond_to?(method_name) && \
-      (model.respond_to?(method_name) || \
-          model.method_defined?(method_name))
+     (model.respond_to?(method_name) || \
+         model.method_defined?(method_name))
     fields << RailsAdmin::Config::Fields::Types::Enum.new(parent, properties.name, properties)
     true
   else

lib/rails_admin/extensions/paper_trail/auditing_adapter.rb

@@ -107,8 +107,8 @@ def listing_for_model_or_object(model, object, query, sort, sort_reverse, all, p
 
         def version_class_for(model_name)
           klass = model_name.constantize.
-            try(:version_class_name).
-            try(:constantize)
+                  try(:version_class_name).
+                  try(:constantize)
 
           klass || @version_class
         end

lib/rails_admin/support/csv_converter.rb

@@ -80,23 +80,23 @@ def generate_csv_header
       @fields.collect do |field|
         ::I18n.t('admin.export.csv.header_for_root_methods', name: field.label, model: @abstract_model.pretty_name)
       end +
-      @associations.flat_map do |_association_name, option_hash|
-        option_hash[:fields].collect do |field|
-          ::I18n.t('admin.export.csv.header_for_association_methods', name: field.label, association: option_hash[:association].label)
+        @associations.flat_map do |_association_name, option_hash|
+          option_hash[:fields].collect do |field|
+            ::I18n.t('admin.export.csv.header_for_association_methods', name: field.label, association: option_hash[:association].label)
+          end
         end
-      end
     end
 
     def generate_csv_row(object)
       @fields.collect do |field|
         field.with(object: object).export_value
       end +
-      @associations.flat_map do |association_name, option_hash|
-        associated_objects = [object.send(association_name)].flatten.compact
-        option_hash[:fields].collect do |field|
-          associated_objects.collect { |ao| field.with(object: ao).export_value.presence || @empty }.join(',')
+        @associations.flat_map do |association_name, option_hash|
+          associated_objects = [object.send(association_name)].flatten.compact
+          option_hash[:fields].collect do |field|
+            associated_objects.collect { |ao| field.with(object: ao).export_value.presence || @empty }.join(',')
+          end
         end
-      end
     end
   end
 end

spec/helpers/rails_admin/application_helper_spec.rb

@@ -69,8 +69,8 @@ def initialize(_user)
             member :test_bindings do
               visible do
                 bindings[:controller].is_a?(ActionView::TestCase::TestController) &&
-                bindings[:abstract_model].model == Team &&
-                bindings[:object].is_a?(Team)
+                  bindings[:abstract_model].model == Team &&
+                  bindings[:object].is_a?(Team)
               end
             end
           end
@@ -97,8 +97,8 @@ def initialize(_user)
             member :test_bindings do
               visible do
                 bindings[:controller].is_a?(ActionView::TestCase::TestController) &&
-                bindings[:abstract_model].model == Team &&
-                bindings[:object].is_a?(Team)
+                  bindings[:abstract_model].model == Team &&
+                  bindings[:object].is_a?(Team)
               end
             end
           end

spec/integration/basic/export/rails_admin_basic_export_spec.rb

@@ -78,7 +78,7 @@
       # and Mongoid with ActiveModel 3.1 does not support to_xml's :include options
       # (due change of implementation in ActiveModel::Serializers between 3.1 and 3.2)
       if RUBY_VERSION =~ /1\.9/ &&
-          (CI_ORM != :mongoid || (CI_ORM == :mongoid && ActiveModel::VERSION::STRING >= '3.2'))
+         (CI_ORM != :mongoid || (CI_ORM == :mongoid && ActiveModel::VERSION::STRING >= '3.2'))
         is_expected.to have_content @player.team.name
       end
     end

spec/rails_admin/adapters/active_record_spec.rb

@@ -95,7 +95,7 @@
     before do
       @abstract_model = RailsAdmin::AbstractModel.new('Team')
       @teams = [{}, {name: 'somewhere foos'}, {manager: 'foo junior'}].
-        collect { |h| FactoryGirl.create :team, h }
+               collect { |h| FactoryGirl.create :team, h }
     end
 
     it 'makes correct query' do
@@ -122,7 +122,7 @@
       @abstract_model = RailsAdmin::AbstractModel.new('Team')
       @division = FactoryGirl.create :division, name: 'bar division'
       @teams = [{}, {division: @division}, {name: 'somewhere foos', division: @division}, {name: 'nowhere foos'}].
-        collect { |h| FactoryGirl.create :team, h }
+               collect { |h| FactoryGirl.create :team, h }
     end
 
     context 'without configuration' do

spec/rails_admin/adapters/mongoid_spec.rb

@@ -192,7 +192,7 @@
     before do
       @abstract_model = RailsAdmin::AbstractModel.new('Player')
       @players = [{}, {name: 'Many foos'}, {position: 'foo shortage'}].
-        collect { |h| FactoryGirl.create :player, h }
+                 collect { |h| FactoryGirl.create :player, h }
     end
 
     it 'makes correct query' do
@@ -205,7 +205,7 @@
       @abstract_model = RailsAdmin::AbstractModel.new('Player')
       @team = FactoryGirl.create :team, name: 'king of bar'
       @players = [{}, {team: @team}, {name: 'Many foos', team: @team}, {name: 'Great foo'}].
-        collect { |h| FactoryGirl.create :player, h }
+                 collect { |h| FactoryGirl.create :player, h }
     end
 
     it 'makes correct query' do