allow crop to work with unformatted dimensions, and test (#714)

Author: rafaqz

Diff for: src/methods/crop_extend.jl

@@ -80,10 +80,10 @@ function crop(xs; to=nothing, kw...)
         map(l -> crop(l; to, kw...), xs)
     end
 end
-crop(x::RasterStackOrArray; to, geometrycolumn=nothing, kw...) = _crop_to(x, to; geometrycolumn, kw...)
+crop(x::RasterStackOrArray; to, kw...) = _crop_to(x, to; kw...)
 
 # crop `A` to values of dims of `to`
-function _crop_to(x, to; geometrycolumn, kw...)
+function _crop_to(x, to; geometrycolumn=nothing, kw...)
     ext = _extent(to; geometrycolumn)
     if isnothing(ext)
         if isnothing(dims(to))
@@ -99,7 +99,7 @@ _crop_to(A, to::RasterStackOrArray; dims=DD.dims(to), kw...) = _crop_to(A, DD.di
 _crop_to(x, to::Dimension; kw...) = _crop_to(x, (to,); kw...)
 function _crop_to(x, to::DimTuple; touches=false, kw...)
     # We can only crop to sampled dims (e.g. not categorical dims like Band)
-    sampled = reduce(to; init=()) do acc, d
+    sampled = reduce(format(to); init=()) do acc, d
         lookup(d) isa AbstractSampled ? (acc..., d) : acc
     end
     return _crop_to(x, Extents.extent(sampled); touches)

Diff for: test/methods.jl

@@ -564,6 +564,20 @@ end
         @test all(extended_r .=== ga_r)
         @test all(map(==, lookup(extended_d), lookup(extended)))
 
+        @testset "unformatted dimension works in crop" begin
+            xdim, ydim = X(1.0:0.2:2.0), Y(1.0:1:2.0)
+            A = Raster(rand((X(1.0:0.2:4.0), ydim)))
+            @test lookup(crop(A; to=xdim), X) == 1.0:0.2:2.0
+
+            A = Raster(rand((X(1.0:0.2:4.0), ydim)))
+            @test lookup(crop(A; to=xdim), X) == 1.0:0.2:2.0
+
+            A = Raster(ones((X(1.0:0.2:1.4), ydim)); missingval=0.0)
+            extend(A; to=xdim)
+            @test lookup(extend(A; to=xdim), X) == 1.0:0.2:2.0
+            @test extend(A; to=xdim) == [1.0 1.0; 1.0 1.0; 1.0 1.0; 0.0 0.0; 0.0 0.0; 0.0 0.0]  
+        end
+
         @testset "to polygons" begin
             A1 = Raster(zeros(X(-20:-5; sampling=Points()), Y(0:30; sampling=Points())))
             A2 = Raster(ones(X(-20:-5; sampling=Points()), Y(0:30; sampling=Points())))